<p>George Joseph <strong>uploaded patch set #8</strong> to this change.</p><p><a href="https://gerrit.asterisk.org/10602">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">backtrace: Refactor ast_bt_get_symbols so it doesn't crash<br><br>We've been seeing crashes in libbfd when we attempt to generate<br>a stack trace from multiple threads. It turns out that libbfd<br>is NOT thread-safe. It can cache the bfd structure and give it to<br>multiple threads without protecting itself. To get around this,<br>we've added a global mutex around the bfd functions and also have<br>refactored the use of those functions to be more efficient and<br>to provide more information about inlined functions.<br><br>Also added a few more tests to test_pbx.c. One just calls<br>ast_assert() and the other calls ast_log_backtrace(). Neither are<br>run by default.<br><br>WARNING: This change necessitated changing the return value of<br>ast_bt_get_symbols() from an array of strings to a VECTOR of<br>strings. However, the use of this function outside Asterisk is not<br>likely.<br><br>ASTERISK-28140<br><br>Change-Id: I79d02862ddaa2423a0809caa4b3b85c128131621<br>---<br>M CHANGES<br>M UPGRADE.txt<br>M include/asterisk/backtrace.h<br>M main/astmm.c<br>M main/backtrace.c<br>M main/logger.c<br>M main/utils.c<br>M tests/test_pbx.c<br>M utils/ael_main.c<br>M utils/check_expr.c<br>M utils/conf2ael.c<br>11 files changed, 328 insertions(+), 183 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/02/10602/8</pre><p>To view, visit <a href="https://gerrit.asterisk.org/10602">change 10602</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10602"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>
<div style="display:none"> Gerrit-Change-Id: I79d02862ddaa2423a0809caa4b3b85c128131621 </div>
<div style="display:none"> Gerrit-Change-Number: 10602 </div>
<div style="display:none"> Gerrit-PatchSet: 8 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>