<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 1:</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">(2 comments)</p><p style="white-space: pre-wrap; word-wrap: break-word;">Eventually a similar patch will need to be done for<br>res_pjsip_refer.c as it will not send the pickup event either.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Jasper,</p><p style="white-space: pre-wrap; word-wrap: break-word;">Were you planning on responding to Richard's feedback?</p><p style="white-space: pre-wrap; word-wrap: break-word;">Thanks,<br>Matthew Fredrickson</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Matthew,</p><p style="white-space: pre-wrap; word-wrap: break-word;">I am having trouble understanding your second comment about the ConfBridge that is not returned in ast_bridge_transfer_acquire_bridge() but is a bridge by the definition of ast_channel_get_bridge(). </p><p style="white-space: pre-wrap; word-wrap: break-word;">I see that ast_bridge_transfer_acquire_bridge has an additional check on a masquerade flag that is related to ConfBridge, but am unsure how that is relevant in the handle_invite_replaces context.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Should I wrap the ast_send_call_pickup_stasis_message call with an if statement on the output of ast_channel_get_bridge()?</p><p style="white-space: pre-wrap; word-wrap: break-word;">Regards,<br>Jasper Hafkenscheid</p><p><a href="https://gerrit.asterisk.org/10448">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10448">change 10448</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10448"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ieb1442027a3ce6ae55faca47bc095e53972f947a </div>
<div style="display:none"> Gerrit-Change-Number: 10448 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Jasper Hafkenscheid <jasper.hafkenscheid@wearespindle.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jasper Hafkenscheid <jasper.hafkenscheid@wearespindle.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Matthew Fredrickson <creslin@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 01 Nov 2018 09:35:02 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-HasLabels: No </div>