<p>George Joseph <strong>uploaded patch set #3</strong> to the change originally created by Torrey Searle.</p><p><a href="https://gerrit.asterisk.org/10528">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">testsuite: fix rewrite_contact tests<br><br>The current rewrite_contact tests put the correct source ip in the<br>headers expected to be rewritten, thus the header re-write has no<br>effect & the test would pass regardless if rewrite_contact is enabled.<br>To fix this, the tests have been updated to have a bogus ip in the<br>route header & ensure that it is either modified, (or remains the same)<br><br>Tests were also added to validate the other half the nat logic, where<br>contact should be updated in the case no route set is present<br><br>Change-Id: Ic3974170dfc3bb878b663359c459a08f9674d9a6<br>---<br>A tests/channels/pjsip/nat/rewrite_contact/contact_request/configs/ast1/extensions.conf<br>A tests/channels/pjsip/nat/rewrite_contact/contact_request/configs/ast1/pjsip.conf<br>A tests/channels/pjsip/nat/rewrite_contact/contact_request/sipp/uac-route-set.xml<br>A tests/channels/pjsip/nat/rewrite_contact/contact_request/test-config.yaml<br>A tests/channels/pjsip/nat/rewrite_contact/contact_response/configs/ast1/extensions.conf<br>A tests/channels/pjsip/nat/rewrite_contact/contact_response/configs/ast1/pjsip.conf<br>A tests/channels/pjsip/nat/rewrite_contact/contact_response/sipp/uas-route-set.xml<br>A tests/channels/pjsip/nat/rewrite_contact/contact_response/test-config.yaml<br>M tests/channels/pjsip/nat/rewrite_contact/route_set_request/sipp/uac-route-set.xml<br>M tests/channels/pjsip/nat/rewrite_contact/route_set_response/sipp/uas-route-set.xml<br>M tests/channels/pjsip/nat/rewrite_contact/tests.yaml<br>11 files changed, 302 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/28/10528/3</pre><p>To view, visit <a href="https://gerrit.asterisk.org/10528">change 10528</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10528"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>
<div style="display:none"> Gerrit-Change-Id: Ic3974170dfc3bb878b663359c459a08f9674d9a6 </div>
<div style="display:none"> Gerrit-Change-Number: 10528 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Torrey Searle <tsearle@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>