<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">(2 comments)</p></blockquote><p><a href="https://gerrit.asterisk.org/10495">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10495/2/res/res_pjsip_sdp_rtp.c">File res/res_pjsip_sdp_rtp.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10495/2/res/res_pjsip_sdp_rtp.c@396">Patch Set #2, Line 396:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> if (codecs.framing) {<br> /* Copy the codecs framing ms even though there is no match */<br> ast_rtp_codecs_set_framing(ast_rtp_instance_get_codecs(session_media->rtp), codecs.framing);<br> }<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Can you elaborate why exactly this is done? I'd expect the stream itself to be rejected, so I'm not […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is the transcoding case and if the framing is not copied then the transcoded payload ends up with the same framing. For example if the A Leg is 40ms ALAW then the B Leg ULAW even though negotiated to 20ms, ends up with 40ms ULAW</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10495/2/res/res_rtp_asterisk.c">File res/res_rtp_asterisk.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10495/2/res/res_rtp_asterisk.c@5165">Patch Set #2, Line 5165:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> framing_inst1 = ast_rtp_codecs_get_framing(ast_rtp_instance_get_codecs(instance1));<br> framing_inst = ast_rtp_codecs_get_framing(ast_rtp_instance_get_codecs(instance));<br> if (framing_inst1 != 0 && framing_inst != framing_inst1) {<br> return -1;<br> }<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">The bridge_native_rtp module already does checks on framing before allowing a bridge to occur - do t […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'll have a look at the code and get back to you</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10495">change 10495</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10495"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ic64b8fc6a140a93fbdb2f97550a40d0ff334e607 </div>
<div style="display:none"> Gerrit-Change-Number: 10495 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Robert Cripps <rcripps@voxbone.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Robert Cripps <rcripps@voxbone.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 25 Oct 2018 14:15:58 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>