<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">This needs ansible to add it to the ps_globals table.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">s/ansible/alembic/</p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/10357">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10357/2/res/res_pjsip/config_global.c">File res/res_pjsip/config_global.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10357/2/res/res_pjsip/config_global.c@576">Patch Set #2, Line 576:</a> <code style="font-family:monospace,monospace">            OPT_BOOL_T, 1, FLDSET(struct global_config, use_callerid_contact));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use OPT_YESNO_T instead of OPT_BOOL_T.  The only difference between the two types is that the yes/no version writes the yes/no string to configuration files instead of the true/false strings.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10357/2/res/res_pjsip_session.c">File res/res_pjsip_session.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10357/2/res/res_pjsip_session.c@796">Patch Set #2, Line 796:</a> <code style="font-family:monospace,monospace">                 pj_strdup2(dlg_pool, &dlg_contact_uri->user, connected_id.number.str);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">There is more than one finding here:</p><ul><li>You need to check the valid flag before you can use the number string.  If the valid flag is not true you cannot use the number string no matter what is there.  S_COR(connected_id.number.valid, connected_id.number.str, "")</li></ul><p style="white-space: pre-wrap; word-wrap: break-word;"></p><ul><li>What if there is no number?</li></ul></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10357">change 10357</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10357"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I9a720e058323f6862a91c62f8a8c1a4b5c087b95 </div>
<div style="display:none"> Gerrit-Change-Number: 10357 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Torrey Searle <tsearle@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 16 Oct 2018 13:05:06 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>