<p>Corey Farrell has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/10486">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">taskprocessor: Warn on unused result from pushing task.<br><br>Add attribute_warn_unused_result to ast_taskprocessor_push,<br>ast_taskprocessor_push_local and ast_threadpool_push. This will help<br>ensure we perform the necessary cleanup upon failure.<br><br>Change-Id: I7e4079bd7b21cfe52fb431ea79e41314520c3f6d<br>---<br>M apps/app_confbridge.c<br>M include/asterisk/taskprocessor.h<br>M include/asterisk/threadpool.h<br>M main/stasis.c<br>M main/taskprocessor.c<br>M main/threadpool.c<br>M tests/test_taskprocessor.c<br>M tests/test_threadpool.c<br>8 files changed, 113 insertions(+), 36 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/86/10486/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/apps/app_confbridge.c b/apps/app_confbridge.c</span><br><span>index a4e5c67..a8eef5e 100644</span><br><span>--- a/apps/app_confbridge.c</span><br><span>+++ b/apps/app_confbridge.c</span><br><span>@@ -1111,13 +1111,16 @@</span><br><span> if (conference->playback_queue) {</span><br><span> struct hangup_data hangup;</span><br><span> hangup_data_init(&hangup, conference);</span><br><span style="color: hsl(0, 100%, 40%);">- ast_taskprocessor_push(conference->playback_queue, hangup_playback, &hangup);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ast_mutex_lock(&hangup.lock);</span><br><span style="color: hsl(0, 100%, 40%);">- while (!hangup.hungup) {</span><br><span style="color: hsl(0, 100%, 40%);">- ast_cond_wait(&hangup.cond, &hangup.lock);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* BUGBUG: how should we handle ast_taskprocess_push failure here? */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!ast_taskprocessor_push(conference->playback_queue, hangup_playback, &hangup)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_mutex_lock(&hangup.lock);</span><br><span style="color: hsl(120, 100%, 40%);">+ while (!hangup.hungup) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_cond_wait(&hangup.cond, &hangup.lock);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_mutex_unlock(&hangup.lock);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- ast_mutex_unlock(&hangup.lock);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> hangup_data_destroy(&hangup);</span><br><span> } else {</span><br><span> /* Playback queue is not yet allocated. Just hang up the channel straight */</span><br><span>diff --git a/include/asterisk/taskprocessor.h b/include/asterisk/taskprocessor.h</span><br><span>index 7c79036..f74989a 100644</span><br><span>--- a/include/asterisk/taskprocessor.h</span><br><span>+++ b/include/asterisk/taskprocessor.h</span><br><span>@@ -213,7 +213,8 @@</span><br><span> * \retval -1 failure</span><br><span> * \since 1.6.1</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-int ast_taskprocessor_push(struct ast_taskprocessor *tps, int (*task_exe)(void *datap), void *datap);</span><br><span style="color: hsl(120, 100%, 40%);">+int ast_taskprocessor_push(struct ast_taskprocessor *tps, int (*task_exe)(void *datap), void *datap)</span><br><span style="color: hsl(120, 100%, 40%);">+ attribute_warn_unused_result;</span><br><span> </span><br><span> /*! \brief Local data parameter */</span><br><span> struct ast_taskprocessor_local {</span><br><span>@@ -239,7 +240,8 @@</span><br><span> * \since 12.0.0</span><br><span> */</span><br><span> int ast_taskprocessor_push_local(struct ast_taskprocessor *tps,</span><br><span style="color: hsl(0, 100%, 40%);">- int (*task_exe)(struct ast_taskprocessor_local *local), void *datap);</span><br><span style="color: hsl(120, 100%, 40%);">+ int (*task_exe)(struct ast_taskprocessor_local *local), void *datap)</span><br><span style="color: hsl(120, 100%, 40%);">+ attribute_warn_unused_result;</span><br><span> </span><br><span> /*!</span><br><span> * \brief Indicate the taskprocessor is suspended.</span><br><span>diff --git a/include/asterisk/threadpool.h b/include/asterisk/threadpool.h</span><br><span>index 0f360c7..77ab8a8 100644</span><br><span>--- a/include/asterisk/threadpool.h</span><br><span>+++ b/include/asterisk/threadpool.h</span><br><span>@@ -186,7 +186,8 @@</span><br><span> * \retval 0 success</span><br><span> * \retval -1 failure</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-int ast_threadpool_push(struct ast_threadpool *pool, int (*task)(void *data), void *data);</span><br><span style="color: hsl(120, 100%, 40%);">+int ast_threadpool_push(struct ast_threadpool *pool, int (*task)(void *data), void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+ attribute_warn_unused_result;</span><br><span> </span><br><span> /*!</span><br><span> * \brief Shut down a threadpool and destroy it</span><br><span>diff --git a/main/stasis.c b/main/stasis.c</span><br><span>index 51f01c0..ce905e8 100644</span><br><span>--- a/main/stasis.c</span><br><span>+++ b/main/stasis.c</span><br><span>@@ -561,7 +561,9 @@</span><br><span> </span><br><span> /* When all that's done, remove the ref the mailbox has on the sub */</span><br><span> if (sub->mailbox) {</span><br><span style="color: hsl(0, 100%, 40%);">- ast_taskprocessor_push(sub->mailbox, sub_cleanup, sub);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_taskprocessor_push(sub->mailbox, sub_cleanup, sub)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* BUGBUG: how do we handle this? */</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> }</span><br><span> </span><br><span> /* Unsubscribing unrefs the subscription */</span><br><span>diff --git a/main/taskprocessor.c b/main/taskprocessor.c</span><br><span>index 91eb7d9..c186620 100644</span><br><span>--- a/main/taskprocessor.c</span><br><span>+++ b/main/taskprocessor.c</span><br><span>@@ -235,7 +235,9 @@</span><br><span> /* Hold a reference during shutdown */</span><br><span> ao2_t_ref(listener->tps, +1, "tps-shutdown");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ast_taskprocessor_push(listener->tps, default_listener_die, pvt);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_taskprocessor_push(listener->tps, default_listener_die, pvt)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* BUGBUG: what do we do here? */</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> ast_assert(pvt->poll_thread != AST_PTHREADT_NULL);</span><br><span> </span><br><span>diff --git a/main/threadpool.c b/main/threadpool.c</span><br><span>index e7abc8f..d2de69a 100644</span><br><span>--- a/main/threadpool.c</span><br><span>+++ b/main/threadpool.c</span><br><span>@@ -658,7 +658,9 @@</span><br><span> }</span><br><span> </span><br><span> if (pool->listener && pool->listener->callbacks->emptied) {</span><br><span style="color: hsl(0, 100%, 40%);">- ast_taskprocessor_push(pool->control_tps, queued_emptied, pool);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_taskprocessor_push(pool->control_tps, queued_emptied, pool)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_log(LOG_ERROR, "Failed to push call, leaks may occur.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> }</span><br><span> }</span><br><span> </span><br><span>diff --git a/tests/test_taskprocessor.c b/tests/test_taskprocessor.c</span><br><span>index 273e045..6428746 100644</span><br><span>--- a/tests/test_taskprocessor.c</span><br><span>+++ b/tests/test_taskprocessor.c</span><br><span>@@ -151,7 +151,10 @@</span><br><span> return AST_TEST_FAIL;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ast_taskprocessor_push(tps, task, task_data);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_taskprocessor_push(tps, task, task_data)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_test_status_update(test, "Failed to queue task\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return AST_TEST_FAIL;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> res = task_wait(task_data);</span><br><span> if (res != 0) {</span><br><span>@@ -240,7 +243,11 @@</span><br><span> </span><br><span> for (i = 0; i < NUM_TASKS; ++i) {</span><br><span> rand_data[i] = ast_random();</span><br><span style="color: hsl(0, 100%, 40%);">- ast_taskprocessor_push(tps, load_task, &rand_data[i]);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_taskprocessor_push(tps, load_task, &rand_data[i])) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_test_status_update(test, "Failed to queue task\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ res = AST_TEST_FAIL;</span><br><span style="color: hsl(120, 100%, 40%);">+ goto test_end;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> }</span><br><span> </span><br><span> ast_mutex_lock(&load_task_results.lock);</span><br><span>@@ -438,14 +445,22 @@</span><br><span> goto test_exit;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ast_taskprocessor_push(tps, listener_test_task, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_taskprocessor_push(tps, listener_test_task, NULL)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_test_status_update(test, "Failed to queue task\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ res = AST_TEST_FAIL;</span><br><span style="color: hsl(120, 100%, 40%);">+ goto test_exit;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> if (check_stats(test, pvt, 1, 0, 1) < 0) {</span><br><span> res = AST_TEST_FAIL;</span><br><span> goto test_exit;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ast_taskprocessor_push(tps, listener_test_task, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_taskprocessor_push(tps, listener_test_task, NULL)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_test_status_update(test, "Failed to queue task\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ res = AST_TEST_FAIL;</span><br><span style="color: hsl(120, 100%, 40%);">+ goto test_exit;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> if (check_stats(test, pvt, 2, 0, 1) < 0) {</span><br><span> res = AST_TEST_FAIL;</span><br><span>@@ -710,7 +725,10 @@</span><br><span> local_data = 0;</span><br><span> ast_taskprocessor_set_local(tps, &local_data);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ast_taskprocessor_push_local(tps, local_task_exe, task_data);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_taskprocessor_push_local(tps, local_task_exe, task_data)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_test_status_update(test, "Failed to queue task\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return AST_TEST_FAIL;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> res = task_wait(task_data);</span><br><span> if (res != 0) {</span><br><span>diff --git a/tests/test_threadpool.c b/tests/test_threadpool.c</span><br><span>index d8acf26..3680a5b 100644</span><br><span>--- a/tests/test_threadpool.c</span><br><span>+++ b/tests/test_threadpool.c</span><br><span>@@ -319,7 +319,9 @@</span><br><span> goto end;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ast_threadpool_push(pool, simple_task, std);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_threadpool_push(pool, simple_task, std)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ goto end;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> wait_for_task_pushed(listener);</span><br><span> </span><br><span>@@ -635,9 +637,11 @@</span><br><span> }</span><br><span> ast_mutex_unlock(&tld->lock);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ast_threadpool_push(pool, simple_task, std);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- res = wait_for_completion(test, std);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_threadpool_push(pool, simple_task, std)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ res = AST_TEST_FAIL;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ res = wait_for_completion(test, std);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> ast_free(std);</span><br><span> </span><br><span>@@ -707,7 +711,9 @@</span><br><span> goto end;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ast_threadpool_push(pool, simple_task, std);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_threadpool_push(pool, simple_task, std)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ goto end;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> ast_threadpool_set_size(pool, 1);</span><br><span> </span><br><span>@@ -796,7 +802,10 @@</span><br><span> goto end;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ast_threadpool_push(pool, simple_task, std);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_threadpool_push(pool, simple_task, std)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ res = AST_TEST_FAIL;</span><br><span style="color: hsl(120, 100%, 40%);">+ goto end;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> res = wait_for_completion(test, std);</span><br><span> if (res == AST_TEST_FAIL) {</span><br><span>@@ -882,9 +891,18 @@</span><br><span> goto end;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ast_threadpool_push(pool, simple_task, std1);</span><br><span style="color: hsl(0, 100%, 40%);">- ast_threadpool_push(pool, simple_task, std2);</span><br><span style="color: hsl(0, 100%, 40%);">- ast_threadpool_push(pool, simple_task, std3);</span><br><span style="color: hsl(120, 100%, 40%);">+ res = AST_TEST_FAIL;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_threadpool_push(pool, simple_task, std1)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ goto end;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_threadpool_push(pool, simple_task, std2)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ goto end;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_threadpool_push(pool, simple_task, std3)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ goto end;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> res = wait_for_completion(test, std1);</span><br><span> if (res == AST_TEST_FAIL) {</span><br><span>@@ -1011,7 +1029,9 @@</span><br><span> goto end;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ast_threadpool_push(pool, simple_task, std1);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_threadpool_push(pool, simple_task, std1)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ goto end;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> /* Pushing the task should result in the threadpool growing</span><br><span> * by three threads. This will allow the task to actually execute</span><br><span>@@ -1034,9 +1054,19 @@</span><br><span> /* Now push three tasks into the pool and ensure the pool does not</span><br><span> * grow.</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">- ast_threadpool_push(pool, simple_task, std2);</span><br><span style="color: hsl(0, 100%, 40%);">- ast_threadpool_push(pool, simple_task, std3);</span><br><span style="color: hsl(0, 100%, 40%);">- ast_threadpool_push(pool, simple_task, std4);</span><br><span style="color: hsl(120, 100%, 40%);">+ res = AST_TEST_FAIL;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_threadpool_push(pool, simple_task, std2)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ goto end;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_threadpool_push(pool, simple_task, std3)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ goto end;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_threadpool_push(pool, simple_task, std4)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ goto end;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> res = wait_for_completion(test, std2);</span><br><span> if (res == AST_TEST_FAIL) {</span><br><span>@@ -1121,7 +1151,9 @@</span><br><span> goto end;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ast_threadpool_push(pool, simple_task, std);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_threadpool_push(pool, simple_task, std)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ goto end;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> res = wait_for_completion(test, std);</span><br><span> if (res == AST_TEST_FAIL) {</span><br><span>@@ -1193,7 +1225,9 @@</span><br><span> goto end;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ast_threadpool_push(pool, simple_task, std1);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_threadpool_push(pool, simple_task, std1)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ goto end;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> ast_threadpool_set_size(pool, 1);</span><br><span> </span><br><span>@@ -1218,7 +1252,10 @@</span><br><span> }</span><br><span> </span><br><span> /* Now make sure the threadpool reactivates when we add a second task */</span><br><span style="color: hsl(0, 100%, 40%);">- ast_threadpool_push(pool, simple_task, std2);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_threadpool_push(pool, simple_task, std2)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ res = AST_TEST_FAIL;</span><br><span style="color: hsl(120, 100%, 40%);">+ goto end;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> res = wait_for_completion(test, std2);</span><br><span> if (res == AST_TEST_FAIL) {</span><br><span>@@ -1400,8 +1437,13 @@</span><br><span> goto end;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ast_threadpool_push(pool, complex_task, ctd1);</span><br><span style="color: hsl(0, 100%, 40%);">- ast_threadpool_push(pool, complex_task, ctd2);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_threadpool_push(pool, complex_task, ctd1)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ goto end;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_threadpool_push(pool, complex_task, ctd2)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ goto end;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> ast_threadpool_set_size(pool, 2);</span><br><span> </span><br><span>@@ -1496,8 +1538,13 @@</span><br><span> goto end;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- ast_threadpool_push(pool, complex_task, ctd1);</span><br><span style="color: hsl(0, 100%, 40%);">- ast_threadpool_push(pool, complex_task, ctd2);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_threadpool_push(pool, complex_task, ctd1)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ goto end;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ast_threadpool_push(pool, complex_task, ctd2)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ goto end;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> ast_threadpool_set_size(pool, 4);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/10486">change 10486</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10486"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7e4079bd7b21cfe52fb431ea79e41314520c3f6d </div>
<div style="display:none"> Gerrit-Change-Number: 10486 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>