<p>Patch set 5:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/10431">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10431/5/res/res_pjsip_sdp_rtp.c">File res/res_pjsip_sdp_rtp.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10431/5/res/res_pjsip_sdp_rtp.c@1249">Patch Set #5, Line 1249:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">          const char *use_media_address = pbx_builtin_getvar_helper(session->channel, "PJSIP_USE_MEDIA_ADDRESS");<br>          if (!ast_strlen_zero(use_media_address)) {<br>                    if (!strcmp("yes", use_media_address)) {<br>                            hostip = session->endpoint->media.address;<br>                      } else if (!strcmp("no", use_media_address)) {<br>                              hostip = ast_sip_get_host_ip_string(session->endpoint->media.rtp.ipv6 ? pj_AF_INET6() : pj_AF_INET());<br>                  } else {<br>                              hostip = session->endpoint->media.address;<br>                      }<br>             } else {<br>                      hostip = session->endpoint->media.address;<br>              }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This block can be simplified to just:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> const char *use_media_address = pbx_builtin_getvar_helper(...);<br> hostip = session->endpoint->media.address;<br> if (!ast_strlen_zero(use_media_address) && !strcmp("no", use_media_address)) {<br>   hostip = ast_sip_get_host_ip_string(...);<br> }</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10431">change 10431</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10431"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I852adbee9f8b034ec332fbe4e1b6692cb2939518 </div>
<div style="display:none"> Gerrit-Change-Number: 10431 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Salah Ahmed <txrubel@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 05 Oct 2018 13:55:04 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>