<p>George Joseph <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/10421">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Sean Bright: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved; Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">core/frame: generate correct T.140 payload in ast_sendtext_data()<br><br>ast_sendtext_data() would create an incorrect T.140 text frame which<br>length include the null terminator byte. It causes ultimately RTP<br>packets to be send with this trailing 0. The proposed fix just set the<br>correct length to the text frame<br><br>ASTERISK-28089<br>Reported by: Emmanuel BUU<br>Tested by: Emmanuel BUU<br><br>Change-Id: I7ab1b9ed1e21683b2b667ea0a59d9aba3c77dd96<br>---<br>M main/channel.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/main/channel.c b/main/channel.c</span><br><span>index 5fc9cd8..d13d3f5 100644</span><br><span>--- a/main/channel.c</span><br><span>+++ b/main/channel.c</span><br><span>@@ -4905,7 +4905,8 @@</span><br><span>            && (ast_strlen_zero(content_type) || ast_begins_with(content_type, "text/"))</span><br><span>               && (ast_format_cap_has_type(ast_channel_nativeformats(chan), AST_MEDIA_TYPE_TEXT))) {</span><br><span>                struct ast_frame f;</span><br><span style="color: hsl(0, 100%, 40%);">-             size_t body_len = strlen(body) + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+           /* T.140 payload does not include the null byte terminator */</span><br><span style="color: hsl(120, 100%, 40%);">+         size_t body_len = strlen(body);</span><br><span> </span><br><span>          /* Process as T.140 text (moved here from ast_sendtext() */</span><br><span>          memset(&f, 0, sizeof(f));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/10421">change 10421</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10421"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I7ab1b9ed1e21683b2b667ea0a59d9aba3c77dd96 </div>
<div style="display:none"> Gerrit-Change-Number: 10421 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Emmanuel BUU <emmanuel.buu@ives.fr> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>