<p>Jaco Kroon has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/9858">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">chan_sip: tcp/tls honour insecure=port<br><br>Prior to b2c4e8660a9c89d07041271371151779b7ec75f6 insecure=port was<br>the defacto standard.  That commit also prevented insecure=port from<br>being applied for sip/tcp or sip/tls.  This just allows insecure=port on<br>all transport types.<br><br>ASTERISK-27881 #close<br><br>Change-Id: I61a9804e4feba9c7224c481f7a10bf7eb7c7f2a2<br>---<br>M channels/chan_sip.c<br>1 file changed, 1 insertion(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/58/9858/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/channels/chan_sip.c b/channels/chan_sip.c</span><br><span>index e23915b..867c6a6 100644</span><br><span>--- a/channels/chan_sip.c</span><br><span>+++ b/channels/chan_sip.c</span><br><span>@@ -34429,9 +34429,7 @@</span><br><span>         }</span><br><span> </span><br><span>        /* We matched the IP, check to see if we need to match by port as well. */</span><br><span style="color: hsl(0, 100%, 40%);">-      if (((peer->transports & peer2->transports) &</span><br><span style="color: hsl(0, 100%, 40%);">-             (AST_TRANSPORT_UDP | AST_TRANSPORT_WS | AST_TRANSPORT_WSS)) &&</span><br><span style="color: hsl(0, 100%, 40%);">-          ast_test_flag(&peer2->flags[0], SIP_INSECURE_PORT)) {</span><br><span style="color: hsl(120, 100%, 40%);">+  if (ast_test_flag(&peer2->flags[0], SIP_INSECURE_PORT)) {</span><br><span>             /* We are allowing match without port for peers configured that</span><br><span>               * way in this pass through the peers. */</span><br><span>            return ast_test_flag(&peer->flags[0], SIP_INSECURE_PORT) ?</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/9858">change 9858</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9858"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I61a9804e4feba9c7224c481f7a10bf7eb7c7f2a2 </div>
<div style="display:none"> Gerrit-Change-Number: 9858 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Jaco Kroon <jaco@uls.co.za> </div>