<p><a href="https://gerrit.asterisk.org/9558">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9558/2/main/bridge_basic.c">File main/bridge_basic.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9558/2/main/bridge_basic.c@3433">Patch Set #2, Line 3433:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">   /* We increase the refcount of the transfer target because ast_bridge_impart() will<br>    * steal the reference we already have. We need to keep a reference, so the only<br>       * choice is to give it a bump<br>         */<br>   ast_channel_ref(props->transfer_target);<br>   if (ast_bridge_impart(props->target_bridge, props->transfer_target, NULL, NULL,<br>         AST_BRIDGE_IMPART_CHAN_INDEPENDENT)) {<br>                ast_log(LOG_ERROR, "Channel %s: Unable to place transfer target into bridge.\n",<br>                    ast_channel_name(bridge_channel->chan));<br>           stream_failsound(props->transferer);<br>               ast_bridge_channel_write_unhold(bridge_channel);<br>              ast_hangup(props->transfer_target);<br>                props->transfer_target = NULL;<br>             attended_transfer_properties_shutdown(props);<br>         return 0;<br>     }<br></pre></blockquote></p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">You need to redo this patch to *only* suppress the *initial*<br>connected line update.  To suppress that connected line update we<br>need to get Alice into the target bridge before the local channel<br>connected to Charlie joins the target bridge with the<br>AST_BRIDGE_IMPART_INHIBIT_JOIN_COLP flag.</p><ul><li>This bridge impart needs to be moved to attended_transfer_monitor_thread().</li><li>The impart needs to be done after Alice is moved to the target</li><li>bridge with bridge_move() in attended_transfer_monitor_thread().</li><li>The impart needs to be done with the AST_BRIDGE_IMPART_INHIBIT_JOIN_COLP</li><li>flag added.</li><li>bridge_move() needs to be modified to not call bridge_do_move if</li><li>the passed in channel is already in the destination bridge.</li><li>Some off-nominal code needs to be fixed-up because of the</li><li>relocated code.</li></ul></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Why is not enough to suppress the *initial* update in calling_target_enter as I did in this patch? It's working.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9558">change 9558</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9558"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I346652661949b6611c23e431ede0dbea1be3017a </div>
<div style="display:none"> Gerrit-Change-Number: 9558 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 02 Aug 2018 20:31:54 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>