<p>Joshua Colp <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/9639">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">res_pjsip: Change log message from error to warning for valid use cases<br><br>If a SIP MESSAGE is triggered for an endpoint that is currently not registered<br>- and therefore has no valid contact associated - an error message was logged.<br>Since this is a valid request in a valid use cases this is now changed to a<br>warning, as discussed with Matt Fredrickson on the asterisk-dev mailing list.<br><br>Change-Id: I55eb62d2712818a58c7532119dec288bd98cf0c0<br>---<br>M res/res_pjsip.c<br>M res/res_pjsip_messaging.c<br>2 files changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/res/res_pjsip.c b/res/res_pjsip.c</span><br><span>index ba06277..4c10051 100644</span><br><span>--- a/res/res_pjsip.c</span><br><span>+++ b/res/res_pjsip.c</span><br><span>@@ -3604,7 +3604,7 @@</span><br><span>                       contact = ast_sip_location_retrieve_contact_from_aor_list(endpoint->aors);</span><br><span>                }</span><br><span>            if (!contact || ast_strlen_zero(contact->uri)) {</span><br><span style="color: hsl(0, 100%, 40%);">-                     ast_log(LOG_ERROR, "Unable to retrieve contact for endpoint %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                  ast_log(LOG_WARNING, "Unable to retrieve contact for endpoint %s\n",</span><br><span>                                       ast_sorcery_object_get_id(endpoint));</span><br><span>                        return -1;</span><br><span>           }</span><br><span>diff --git a/res/res_pjsip_messaging.c b/res/res_pjsip_messaging.c</span><br><span>index 45315d5..224721e 100644</span><br><span>--- a/res/res_pjsip_messaging.c</span><br><span>+++ b/res/res_pjsip_messaging.c</span><br><span>@@ -656,7 +656,7 @@</span><br><span>     }</span><br><span> </span><br><span>        if (ast_sip_create_request("MESSAGE", NULL, endpoint, uri, NULL, &tdata)) {</span><br><span style="color: hsl(0, 100%, 40%);">-               ast_log(LOG_ERROR, "PJSIP MESSAGE - Could not create request\n");</span><br><span style="color: hsl(120, 100%, 40%);">+           ast_log(LOG_WARNING, "PJSIP MESSAGE - Could not create request\n");</span><br><span>                return -1;</span><br><span>   }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/9639">change 9639</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9639"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I55eb62d2712818a58c7532119dec288bd98cf0c0 </div>
<div style="display:none"> Gerrit-Change-Number: 9639 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Florian Floimair <f.floimair@commend.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>