<p><a href="https://gerrit.asterisk.org/9505">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9505/3/res/res_pjsip_outbound_registration.c">File res/res_pjsip_outbound_registration.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/3/res/res_pjsip_outbound_registration.c@354">Patch Set #3, Line 354:</a> <code style="font-family:monospace,monospace">static pj_pool_t *reg_pool;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">The use of this pool in this file is problematic. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Agreed. Removed in patchset 4.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/3/res/res_pjsip_outbound_registration.c@660">Patch Set #3, Line 660:</a> <code style="font-family:monospace,monospace">        data = ast_malloc(sizeof(struct stateless_send_resolver_callback_data));</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This can fail and go kaboom.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Agreed. Fixed in patchset 4.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/3/res/res_pjsip_outbound_registration.c@2593">Patch Set #3, Line 2593:</a> <code style="font-family:monospace,monospace">}</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Any reason this couldn't alter the transport information instead of using the callback? Did you just […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yes, setting the transport here does not good as pjsip_regc_send() overrides the transport to use the one set by pjsip_regc_set_transport().</p><p style="white-space: pre-wrap; word-wrap: break-word;">callback mechanism is only to avoid a circular dependency between res_pjsip and res_pjsip_outbound_authentication: res_pjsip_outbound_auth depends on res_pjsip, but then the dialog creation code in res_pjsip needs a way to access outbound's global client state to find registration's transport.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9505/3/third-party/pjproject/patches/0110-oauth.patch">File third-party/pjproject/patches/0110-oauth.patch:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/3/third-party/pjproject/patches/0110-oauth.patch@70">Patch Set #3, Line 70:</a> <code style="font-family:monospace,monospace">+                else //if (pj_stricmp(&c->scheme, &pjsip_DIGEST_STR)==0)</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Should this still be commented out or just removed?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Just commenting that the else case is for DIGEST.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9505">change 9505</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9505"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id214c2d1c550a41fcf564b7df8f3da7be565bd58 </div>
<div style="display:none"> Gerrit-Change-Number: 9505 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Nick French <naf@ou.edu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nick French <naf@ou.edu> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 25 Jul 2018 22:10:26 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>