<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/9658">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9658/1/main/devicestate.c">File main/devicestate.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9658/1/main/devicestate.c@761">Patch Set #1, Line 761:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">     /* When this device state change is not cached we only publish<br>         * on its own pool topic if one already exists. This means that<br>        * something external is explicitly monitoring it.<br>     */<br>   if (cachable || stasis_topic_pool_check_topic(device_state_topic_pool, device)) {<br>             topic = ast_device_state_topic(device);<br>       } else {<br>              topic = ast_device_state_topic_all();<br> }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm not following how the logic matches your description.  Does check topic return true if it's NOT cached?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9658/1/main/stasis.c">File main/stasis.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9658/1/main/stasis.c@1201">Patch Set #1, Line 1201:</a> <code style="font-family:monospace,monospace">stasis_topic_pool_check_topic</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Think you can rename this to something like stasis_topic_pool_topic_exists?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9658">change 9658</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9658"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I18da0e8cbb18e79602e731020c46ba4101e59f0a </div>
<div style="display:none"> Gerrit-Change-Number: 9658 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 25 Jul 2018 18:03:27 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>