<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/9504">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9504/1/apps/app_adsiprog.c">File apps/app_adsiprog.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9504/1/apps/app_adsiprog.c@1613">Patch Set #1, Line 1613:</a> <code style="font-family:monospace,monospace">     .support_level = AST_MODULE_SUPPORT_EXTENDED,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">AST_MODULE_SUPPORT_DEPRECATED</p><p style="white-space: pre-wrap; word-wrap: break-word;">This should be done for other modules that have been marked as deprecated.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9504/1/apps/app_ices.c">File apps/app_ices.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9504/1/apps/app_ices.c@214">Patch Set #1, Line 214:</a> <code style="font-family:monospace,monospace">AST_MODULE_INFO_STANDARD_EXTENDED(ASTERISK_GPL_KEY, "Encode and Stream via icecast and ices");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">AST_MODULE_INFO_STANDARD_DEPRECATED</p><p style="white-space: pre-wrap; word-wrap: break-word;">This should be done for other modules that have been marked as deprecated.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9504/1/channels/chan_misdn.c">File channels/chan_misdn.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9504/1/channels/chan_misdn.c@79">Patch Set #1, Line 79:</a> <code style="font-family:monospace,monospace">   <support_level>deprecated</support_level></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should add that chan_dahdi with libpri replaces this channel driver.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'd really like to see this module deleted too since it cannot be built on current OS's but Sean Bright seems to want it hanging around. :)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9504/1/channels/chan_vpb.cc">File channels/chan_vpb.cc:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9504/1/channels/chan_vpb.cc@53">Patch Set #1, Line 53:</a> <code style="font-family:monospace,monospace"> <support_level>deprecated</support_level></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'd really like to see this one just deleted.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9504">change 9504</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9504"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I64783d017b86dba9ee3c7bcfb97e59889a3f76d7 </div>
<div style="display:none"> Gerrit-Change-Number: 9504 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 18 Jul 2018 16:49:12 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>