<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/9179">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(5 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/9179/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9179/1//COMMIT_MSG@14">Patch Set #1, Line 14:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">checks if mpg123 is still running before poll again.<br><br>Change-Id: Ib7df8462e3e380cb328011890ad9270d9e9b4620<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">You are missing the ASTERISK issue identifier here in the commit message.<br>https://wiki.asterisk.org/wiki/display/AST/Commit+Messages</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/9179/1/apps/app_mp3.c">File apps/app_mp3.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9179/1/apps/app_mp3.c@147">Patch Set #1, Line 147:</a> <code style="font-family:monospace,monospace"> for(i=0; i<timeout; i++) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Guidelines: Spaces around binary operators<br>for (i = 0; i < timeout; ++i) {<br>}</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9179/1/apps/app_mp3.c@152">Patch Set #1, Line 152:</a> <code style="font-family:monospace,monospace"> // is mpg123 still running?</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Guidelines: No C++ style comments.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9179/1/apps/app_mp3.c@164">Patch Set #1, Line 164:</a> <code style="font-family:monospace,monospace"> ast_log(LOG_NOTICE, "Poll timed out/errored out with %d\n", res);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This message is no longer right. Should just be:<br>"Poll timed out.\n"</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9179/1/apps/app_mp3.c@240">Patch Set #1, Line 240:</a> <code style="font-family:monospace,monospace"> res = timed_read(fds[0], myf.frdata, sizeof(myf.frdata), timeout, mpg123pid);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Creating mpg123pid is completely unnecessary. There is already a variable called pid with the child pid.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9179">change 9179</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9179"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib7df8462e3e380cb328011890ad9270d9e9b4620 </div>
<div style="display:none"> Gerrit-Change-Number: 9179 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Sam Wierema <sam@messagebird.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 12 Jun 2018 21:50:31 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>