<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8883">View Change</a></p><p>Patch set 2:</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8883/2/res/res_rtp_asterisk.c">File res/res_rtp_asterisk.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8883/2/res/res_rtp_asterisk.c@4424">Patch Set #2, Line 4424:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> /* 4 bytes for the shared information, 4 bytes for abs-send-time */<br> hdrlen += 8;<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">It's not adding two uint32s. It's 4 + 1 + 3. 4 bytes for shared information</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ah. I see. Then we don't need to put the whole second uint32 in the buffer to then overwrite most of it with the uint24.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8883/2/res/res_rtp_asterisk.c@4446">Patch Set #2, Line 4446:</a> <code style="font-family:monospace,monospace"> put_unaligned_uint32(rtpheader + 16, htonl((abs_send_time_id << 28) | (2 << 24)));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This can be replaced with:<br>rtpheader[16] = (abs_send_time_id << (28 - 24) | 2 << (24 - 24);<br>or simplified<br>rtpheader[16] = (abs_send_time_id << 4) | 2;</p><p style="white-space: pre-wrap; word-wrap: break-word;">since we only care about the most significant byte. The next three are set to the time.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8883">change 8883</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8883"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I508deac557867b1e27fc7339be890c8018171588 </div>
<div style="display:none"> Gerrit-Change-Number: 8883 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 03 May 2018 21:11:35 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>