<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8888">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">-1 because of the parameter naming inconsistencies.</p><p>(6 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8888/1/include/asterisk/iostream.h">File include/asterisk/iostream.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8888/1/include/asterisk/iostream.h@a65">Patch Set #1, Line 65:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should keep this as it describes what the function returns.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8888/1/include/asterisk/iostream.h@a85">Patch Set #1, Line 85:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should keep this as it describes what the function returns.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8888/1/include/asterisk/iostream.h@a99">Patch Set #1, Line 99:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should keep this as it describes what the function returns.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8888/1/include/asterisk/iostream.h@154">Patch Set #1, Line 154:</a> <code style="font-family:monospace,monospace">ssize_t ast_iostream_read(struct ast_iostream *stream, void *buffer, size_t count);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Changing the second parameter name to buffer makes parameter inconsistent with the doxygen and the actual function definition.</p><p style="white-space: pre-wrap; word-wrap: break-word;">The third parameter of the function definition is size not count.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8888/1/include/asterisk/iostream.h@170">Patch Set #1, Line 170:</a> <code style="font-family:monospace,monospace">ssize_t ast_iostream_gets(struct ast_iostream *stream, char *buffer, size_t size);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Changing the second parameter name to buffer makes parameter inconsistent with the doxygen and the actual function definition.</p><p style="white-space: pre-wrap; word-wrap: break-word;">The third parameter of the function definition is count not size.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8888/1/include/asterisk/iostream.h@209">Patch Set #1, Line 209:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ssize_t __attribute__((format(printf, 2, 3))) ast_iostream_printf(<br> struct ast_iostream *stream, const char *format, ...);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The second parameter of the function definition is fmt not format.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8888">change 8888</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8888"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id71b87637f0a484eb5a1cd26c3d1c7c15c7dcf26 </div>
<div style="display:none"> Gerrit-Change-Number: 8888 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 02 May 2018 21:02:46 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>