<p>Kevin Harwell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8820">View Change</a></p><p>Patch set 1:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8820/1/main/translate.c">File main/translate.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8820/1/main/translate.c@543">Patch Set #1, Line 543:</a> <code style="font-family:monospace,monospace"> res.subclass.format = ast_format_cache_get_slin_by_rate(8000); /* ref bumped on dup */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">What happens with other sample rate paths?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't understand the question. We only try to fill with generic plc on frames of 8K slin. Before setting the format here I check that that was format that was going to be written to. Otherwise NULL is returned and work like they always have.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8820">change 8820</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8820"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I133d084da87adef913bf2ecc9c9240e3eaf4f40a </div>
<div style="display:none"> Gerrit-Change-Number: 8820 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 24 Apr 2018 19:38:43 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>