<p>Joshua Colp <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8820">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8820/1/formats/format_sln.c">File formats/format_sln.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8820/1/formats/format_sln.c@60">Patch Set #1, Line 60:</a> <code style="font-family:monospace,monospace">     if (f->datalen == 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add a comment about why this exists (should this be higher up?)</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8820/1/main/translate.c">File main/translate.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8820/1/main/translate.c@534">Patch Set #1, Line 534:</a> <code style="font-family:monospace,monospace">      * If we've gotten here then we should have an iterpolated frame that was not handled</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">interpolated</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8820/1/main/translate.c@543">Patch Set #1, Line 543:</a> <code style="font-family:monospace,monospace">       res.subclass.format = ast_format_cache_get_slin_by_rate(8000); /* ref bumped on dup */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">What happens with other sample rate paths?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8820">change 8820</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8820"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I133d084da87adef913bf2ecc9c9240e3eaf4f40a </div>
<div style="display:none"> Gerrit-Change-Number: 8820 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 23 Apr 2018 13:02:39 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>