<p>Matthew Fredrickson <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8683">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8683/1/channels/chan_pjsip.c">File channels/chan_pjsip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8683/1/channels/chan_pjsip.c@973">Patch Set #1, Line 973:</a> <code style="font-family:monospace,monospace">                        ast_debug(3, "Channel %s stream %d is of type '%s', not video!\n",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Could we make this debug say something more descriptive, like "Trying to write RTCP REMB on non-video stream of channel %s stream %d type %s".  Also, maybe should be an error instead of debug?</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8683/1/res/res_rtp_asterisk.c">File res/res_rtp_asterisk.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8683/1/res/res_rtp_asterisk.c@4527">Patch Set #1, Line 4527:</a> <code style="font-family:monospace,monospace">   if (!rtp || !rtp->rtcp || (feedback->fmt != AST_RTP_RTCP_FMT_REMB)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Maybe warn here if we get a request to send feedback->fmt that's != AST_RTP_RTCP_FMT_REMB</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8683/1/res/res_rtp_asterisk.c@4532">Patch Set #1, Line 4532:</a> <code style="font-family:monospace,monospace"> if (!ast_rtp_instance_get_prop(instance, AST_RTP_PROPERTY_REMB)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should we debug/error message here?</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8683/1/res/res_rtp_asterisk.c@4574">Patch Set #1, Line 4574:</a> <code style="font-family:monospace,monospace">               rtp_write_rtcp_fir(instance, rtp, &remote_address);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Good change!</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8683">change 8683</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8683"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ic53f821c1560d8924907ad82c4d9c0bc322b38cd </div>
<div style="display:none"> Gerrit-Change-Number: 8683 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Matthew Fredrickson <creslin@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 06 Apr 2018 14:28:01 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>