<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8641">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">I think you still missed some prints:</p><p style="white-space: pre-wrap; word-wrap: break-word;">asterisk(review/corey_farrell/python3-compat)$ pyflakes3 contrib/<br>contrib/scripts/sip_to_pjsip/astconfigparser.py:448:40: invalid<br>syntax<br>print "Could not open file ", filename, " for reading"<br>^<br>contrib/scripts/sip_to_pjsip/sip_to_pjsip.py:94:45: inconsistent<br>use of tabs and spaces in indentation<br>disallow = sip.get(section, 'disallow')[0]<br>^<br>contrib/scripts/sip_to_pjsip/sip_to_pjsql.py:21:36: invalid syntax<br>print "Could not open file ", filename, " for writing"<br>^<br>contrib/scripts/sip_to_pjsip/sqlconfigparser.py:64:25: invalid<br>syntax<br>except Exception,e:<br>^<br>contrib/ast-db-manage/config/versions/28887f25a46f_create_queue_tables.py:32:<br>'alembic.context' imported but unused</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Thanks for pointing out sip_to_pjsip and for letting me know about pyflakes3.  I'm planning to fix sip_to_pjsip in a separate commit as I'm concerned I won't get it right on the first try and I'd like to get the build system fixed.  pyflakes3 has captured a couple things from rest-api-templates that I missed so I'll be updating this review for those issues.  Surprising thing is `make ari-stubs` worked with python3, so I'm confused by that.</p><ul style="list-style: none; padding-left: 20px;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8641">change 8641</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8641"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: If5c5b556a2800d41a3e2cfef080ac2e151178c33 </div>
<div style="display:none"> Gerrit-Change-Number: 8641 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Tzafrir Cohen <tzafrir.cohen@xorcom.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 05 Apr 2018 14:41:30 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>