<p>Jenkins2 <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/8697">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Corey Farrell: Looks good to me, but someone else must approve
Benjamin Keith Ford: Looks good to me, but someone else must approve
Joshua Colp: Looks good to me, approved
Jenkins2: Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">rest_api blind transfer tests fail due to unregistered contacts<br><br>Two tests rest_api/external_interaction/blind_transfer tests:<br><br>stasis_bridge_to_different_stasis_app<br>stasis_bridge_to_same_stasis_app<br><br>failed because pjsua accounts were not yet available to the transfer module.<br>This is because there is a race condition between registering of configured<br>accounts and initializing the transfer module. If the initialization happens<br>before receiving registers then then test fails due to missing accounts.<br><br>This patch makes affected tests just use static contacts instead of waiting<br>on registers since the test does not depend upon that. That way all pjsua<br>endpoints are always considered "ready" before the call to call_transfer<br>initialization.<br><br>Change-Id: Iab1a86a876f160753c74c261620fe383599742a4<br>---<br>M tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/test-config.yaml<br>M tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/test-config.yaml<br>2 files changed, 8 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/test-config.yaml b/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/test-config.yaml<br>index 257054d..11061ba 100644<br>--- a/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/test-config.yaml<br>+++ b/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/test-config.yaml<br>@@ -51,6 +51,8 @@<br> bind: '127.0.0.1'<br> bindport: '5062'<br> accounts:<br>+ # Use static contacts due to race condition between 'reg_success' and<br>+ # 'call_transfer' method calls.<br> -<br> name: 'alice'<br> username: 'alice'<br>@@ -58,12 +60,14 @@<br> transport: 'local-ipv4-1'<br> call_uri: 'sip:stasis@127.0.0.1'<br> transfer_uri: 'sip:1000@127.0.0.1'<br>+ register: False<br> -<br> name: 'bob'<br> username: 'bob'<br> domain: '127.0.0.1'<br> transport: 'local-ipv4-2'<br> call_uri: 'sip:stasis@127.0.0.1'<br>+ register: False<br> <br> pluggable-config:<br> # Upon kickoff channel entering Stasis app: create a bridge, don't add<br>diff --git a/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/test-config.yaml b/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/test-config.yaml<br>index 5298b41..59fe408 100644<br>--- a/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/test-config.yaml<br>+++ b/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/test-config.yaml<br>@@ -47,6 +47,8 @@<br> bind: '127.0.0.1'<br> bindport: '5062'<br> accounts:<br>+ # Use static contacts due to race condition between 'reg_success' and<br>+ # 'call_transfer' method calls.<br> -<br> name: 'alice'<br> username: 'alice'<br>@@ -54,12 +56,14 @@<br> transport: 'local-ipv4-1'<br> call_uri: 'sip:stasis@127.0.0.1'<br> transfer_uri: 'sip:1000@127.0.0.1'<br>+ register: False<br> -<br> name: 'bob'<br> username: 'bob'<br> domain: '127.0.0.1'<br> transport: 'local-ipv4-2'<br> call_uri: 'sip:stasis@127.0.0.1'<br>+ register: False<br> <br> pluggable-config:<br> # Upon kickoff channel entering Stasis app: create a bridge, don't add<br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/8697">change 8697</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8697"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Iab1a86a876f160753c74c261620fe383599742a4 </div>
<div style="display:none"> Gerrit-Change-Number: 8697 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>