<p>George Joseph <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8605">View Change</a></p><p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8605/4/tests/test_data_buffer.c">File tests/test_data_buffer.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8605/4/tests/test_data_buffer.c@71">Patch Set #4, Line 71:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">   if (!buffer) {<br>                ast_test_status_update(test, "Failed to create buffer with valid arguments");<br>               return AST_TEST_FAIL;<br> }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">You can replace this whole block with...<br>ast_test_validate(test, buffer != NULL, "Failed to create buffer with valid arguments");</p><p style="white-space: pre-wrap; word-wrap: break-word;">This does the test and if it fails, automatically prints the error message and returns AST_TEST_FAIL.  The RAII_VAR takes care of the cleanup.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8605">change 8605</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8605"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id5b599aa15a5e61d0ec080f97cd0c57bd07e6f8f </div>
<div style="display:none"> Gerrit-Change-Number: 8605 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 20 Mar 2018 18:38:28 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>