<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8553">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">Here's your -1 so as not to dissappoint you. :)</p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8553/1/main/channel.c">File main/channel.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8553/1/main/channel.c@6571">Patch Set #1, Line 6571:</a> <code style="font-family:monospace,monospace">  * even if the formats are teh same.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">It is spelled: the<br>:)</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8553/1/main/channel.c@6573">Patch Set #1, Line 6573:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">     if ((ast_format_cmp(best_dst_fmt, best_src_fmt) == AST_FORMAT_CMP_NOT_EQUAL<br>           || (ast_opt_generic_plc && ast_opt_generic_plc_on_equal_codecs))<br>              && (ast_opt_generic_plc || ast_opt_transcode_via_slin)) {<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This logic can be simplified since you force ast_opt_generic_plc_on_equal_codecs to false when ast_opt_generic_plc is false.</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">if (ast_opt_generic_plc_on_equal_codecs<br>    || (ast_format_cmp(best_dst_fmt, best_src_fmt) == AST_FORMAT_CMP_NOT_EQUAL<br>    && (ast_opt_generic_plc || ast_opt_transcode_via_slin))) {<br>}</pre></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8553/1/main/channel.c@6576">Patch Set #1, Line 6576:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">          int use_slin = (ast_format_cache_is_slinear(best_src_fmt)<br>                     || ast_format_cache_is_slinear(best_dst_fmt)) ? 1 : 0;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">We need to force translation through signed linear no matter how many translation steps there are otherwise when ast_opt_generic_plc_on_equal_codecs is enabled.</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">int use_slin = (ast_format_cache_is_slinear(best_src_fmt)<br>   || ast_format_cache_is_slinear(best_dst_fmt))<br> ? 1 : ast_opt_generic_plc_on_equal_codecs;</pre></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8553/1/main/channel.c@7671">Patch Set #1, Line 7671:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">           }<br>             else if (!strcasecmp(var->name, "genericplc_on_equal_codecs")) {<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">} else if () {</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8553">change 8553</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8553"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I0577026a179dea34232e63123254b4e0508378f4 </div>
<div style="display:none"> Gerrit-Change-Number: 8553 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 19 Mar 2018 15:58:46 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>