<p>Joshua Colp has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/8602">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pjsip/sdp_offer_answer: Add test for presence of 'goog-remb'.<br><br>This adds a WebRTC SDP offer answer test which confirms that<br>for video streams we place a goog-remb rtcp-fb attribute into<br>the SDP.<br><br>Change-Id: Ic8c50e2edbc418bb753cdec7b10aab96e4d5d345<br>---<br>M tests/channels/pjsip/sdp_offer_answer/tests.yaml<br>A tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/configs/ast1/extensions.conf<br>A tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/configs/ast1/pjsip.conf<br>A tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/sipp/reject.xml<br>A tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/test-config.yaml<br>A tests/channels/pjsip/sdp_offer_answer/webrtc/tests.yaml<br>6 files changed, 104 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/02/8602/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/tests/channels/pjsip/sdp_offer_answer/tests.yaml b/tests/channels/pjsip/sdp_offer_answer/tests.yaml<br>index b0e0de9..db42d34 100644<br>--- a/tests/channels/pjsip/sdp_offer_answer/tests.yaml<br>+++ b/tests/channels/pjsip/sdp_offer_answer/tests.yaml<br>@@ -2,3 +2,4 @@<br> tests:<br> - dir: 'incoming'<br> - dir: 'attribute_passthrough'<br>+ - dir: 'webrtc'<br>diff --git a/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/configs/ast1/extensions.conf b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/configs/ast1/extensions.conf<br>new file mode 100644<br>index 0000000..9897089<br>--- /dev/null<br>+++ b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/configs/ast1/extensions.conf<br>@@ -0,0 +1,3 @@<br>+[default]<br>+exten => nowhere,1,NoOp()<br>+exten => webrtc,1,Dial(PJSIP/webrtc)<br>diff --git a/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/configs/ast1/pjsip.conf b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/configs/ast1/pjsip.conf<br>new file mode 100644<br>index 0000000..0d794df<br>--- /dev/null<br>+++ b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/configs/ast1/pjsip.conf<br>@@ -0,0 +1,25 @@<br>+[global]<br>+type=global<br>+debug=yes<br>+<br>+[local-transport-udp]<br>+type=transport<br>+bind=127.0.0.1<br>+protocol=udp<br>+<br>+[endpoint-template](!)<br>+type=endpoint<br>+context=default<br>+media_address=127.0.0.1<br>+direct_media=no<br>+webrtc=yes<br>+<br>+[webrtc](endpoint-template)<br>+aors=webrtc<br>+disallow=all<br>+allow=ulaw<br>+allow=vp9<br>+<br>+[webrtc]<br>+type=aor<br>+contact=sip:127.0.0.1:5061<br>diff --git a/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/sipp/reject.xml b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/sipp/reject.xml<br>new file mode 100644<br>index 0000000..ed5f438<br>--- /dev/null<br>+++ b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/sipp/reject.xml<br>@@ -0,0 +1,31 @@<br>+<?xml version="1.0" encoding="ISO-8859-1" ?><br>+<!DOCTYPE scenario SYSTEM "sipp.dtd"><br>+<br>+<scenario name="Receive a WebRTC INVITE with goog-remb"><br>+ <recv request="INVITE" crlf="true"><br>+ <action><br>+ <ereg regexp="a=rtcp-fb:\* goog-remb"<br>+ search_in="body" check_it="true" assign_to="1"/><br>+ <strcmp assign_to="1" variable="1" value=""/><br>+<br>+ </action><br>+ </recv><br>+<br>+ <send><br>+ <![CDATA[<br>+<br>+ SIP/2.0 486 Busy Here<br>+ [last_Via:]<br>+ [last_From:]<br>+ [last_To:];tag=[call_number]<br>+ [last_Call-ID:]<br>+ [last_CSeq:]<br>+ Contact: <sip:[local_ip]:[local_port];transport=[transport]><br>+ Content-Length: 0<br>+<br>+ ]]><br>+ </send><br>+<br>+ <recv request="ACK" optional="false" /><br>+<br>+</scenario><br>diff --git a/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/test-config.yaml b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/test-config.yaml<br>new file mode 100644<br>index 0000000..833ac86<br>--- /dev/null<br>+++ b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/test-config.yaml<br>@@ -0,0 +1,41 @@<br>+testinfo:<br>+ summary: 'Test SDP rtcp-fb attribute negotiation of goog-remb'<br>+ description: |<br>+ This tests that when webrtc support is enabled goog-remb is present in the SDP.<br>+<br>+test-modules:<br>+ test-object:<br>+ config-section: sipp-config<br>+ typename: sipp.SIPpTestCase<br>+ modules:<br>+ -<br>+ config-section: originator-config<br>+ typename: pluggable_modules.Originator<br>+<br>+sipp-config:<br>+ memcheck-delay-stop: 7<br>+ stop-after-scenarios: true<br>+ test-iterations:<br>+ -<br>+ scenarios:<br>+ - { 'key-args': {'scenario': 'reject.xml', '-i': '127.0.0.1', '-p': '5061' }}<br>+<br>+originator-config:<br>+ channel: 'Local/webrtc@default'<br>+ ignore-originate-failure: 'yes'<br>+ context: 'default'<br>+ exten: 'nowhere'<br>+ priority: '1'<br>+ trigger: 'scenario_start'<br>+ scenario-name: 'reject.xml'<br>+<br>+properties:<br>+ dependencies:<br>+ - sipp :<br>+ version : 'v3.0'<br>+ - asterisk : 'res_pjsip'<br>+ - asterisk : 'res_pjsip_session'<br>+ - asterisk : 'res_pjsip_sdp_rtp'<br>+ - asterisk : 'chan_pjsip'<br>+ tags:<br>+ - pjsip<br>diff --git a/tests/channels/pjsip/sdp_offer_answer/webrtc/tests.yaml b/tests/channels/pjsip/sdp_offer_answer/webrtc/tests.yaml<br>new file mode 100644<br>index 0000000..c59597f<br>--- /dev/null<br>+++ b/tests/channels/pjsip/sdp_offer_answer/webrtc/tests.yaml<br>@@ -0,0 +1,3 @@<br>+# Enter tests here in the order they should be considered for execution:<br>+tests:<br>+ - test: 'goog-remb'<br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/8602">change 8602</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8602"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic8c50e2edbc418bb753cdec7b10aab96e4d5d345 </div>
<div style="display:none"> Gerrit-Change-Number: 8602 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>