<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8451">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8451/2/channels/chan_sip.c">File channels/chan_sip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8451/2/channels/chan_sip.c@22343">Patch Set #2, Line 22343:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ast_log(LOG_DEBUG, "\n---------- SIP HISTORY for '%s' \n", dialog->callid);<br> if (dialog->subscribed) {<br> ast_log(LOG_DEBUG, " * Subscription\n");<br> } else {<br> ast_log(LOG_DEBUG, " * SIP Call\n");<br> }<br> if (dialog->history) {<br> AST_LIST_TRAVERSE(dialog->history, hist, list)<br> ast_log(LOG_DEBUG, " %-3.3d. %s\n", ++x, hist->event);<br> }<br> if (!x) {<br> ast_log(LOG_DEBUG, "Call '%s' has no history\n", dialog->callid);<br> }<br> ast_log(LOG_DEBUG, "\n---------- END SIP HISTORY for '%s' \n", dialog->callid);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Heh. This change appears to fix a bug in the bargain.</p><p style="white-space: pre-wrap; word-wrap: break-word;">The notice message earlier in the function says the logging happens when either SIP or Asterisk DEBUG logging is enabled. Before it only went out if Asterisk DEBUG logging was enabled. Now it goes out when either is enabled.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8451/2/main/config.c">File main/config.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8451/2/main/config.c@2790">Patch Set #2, Line 2790:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> if (!DEBUG_ATLEAST(1)) {<br> ast_verb(2, "Saving '%s': saved\n", fn);<br> }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The original test was bizarre. Only attempt the verbose log if debugging not enabled?</p><p style="white-space: pre-wrap; word-wrap: break-word;">Should just do ast_verb(2...)</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8451/2/main/sched.c">File main/sched.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8451/2/main/sched.c@721">Patch Set #2, Line 721:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ast_log(LOG_DEBUG, "Asterisk Schedule Dump (%zu in Q, %u Total, %u Cache, %u high-water)\n", ast_heap_size(con->sched_heap), con->eventcnt - 1, con->schedccnt, con->highwater);<br>#else<br> ast_log(LOG_DEBUG, "Asterisk Schedule Dump (%zu in Q, %u Total, %u high-water)\n", ast_heap_size(con->sched_heap), con->eventcnt - 1, con->highwater);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'd be nice if these long lines were broken after the format string. :)</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8451/2/res/res_rtp_asterisk.c">File res/res_rtp_asterisk.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8451/2/res/res_rtp_asterisk.c@4167">Patch Set #2, Line 4167:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> if (DEBUG_ATLEAST(1)) {<br> ast_log(LOG_DEBUG, "Ooh, format changed from %s to %s\n",<br> ast_format_get_name(rtp->lasttxformat),<br> ast_format_get_name(frame->subclass.format));<br> }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is really just an ast_debug(1,...) now.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8451">change 8451</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8451"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ic342d4799a945dbc40ac085ac142681094a4ebf0 </div>
<div style="display:none"> Gerrit-Change-Number: 8451 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 07 Mar 2018 21:38:05 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>