<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8303">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(6 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8303/1/tests/channels/pjsip/basic_calls/outgoing/nominal/early_media/configs/ast1/extensions.conf">File tests/channels/pjsip/basic_calls/outgoing/nominal/early_media/configs/ast1/extensions.conf:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8303/1/tests/channels/pjsip/basic_calls/outgoing/nominal/early_media/configs/ast1/extensions.conf@10">Patch Set #1, Line 10:</a> <code style="font-family:monospace,monospace">exten => s,1,UserEvent(rtpinfo,dest: ${CHANNEL(rtp,dest)})</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This dialplan routine must return.<br>Before returning you should make the call hangup:</p><p style="white-space: pre-wrap; word-wrap: break-word;">same = n,SoftHangup(PJSIP/ua1)<br>same = n,Return()</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8303/1/tests/channels/pjsip/basic_calls/outgoing/nominal/early_media/sipp/ua1_invite_recv.xml">File tests/channels/pjsip/basic_calls/outgoing/nominal/early_media/sipp/ua1_invite_recv.xml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8303/1/tests/channels/pjsip/basic_calls/outgoing/nominal/early_media/sipp/ua1_invite_recv.xml@16">Patch Set #1, Line 16:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">red blob<br>i.e. Trailing whitespace</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8303/1/tests/channels/pjsip/basic_calls/outgoing/nominal/early_media/sipp/ua1_invite_recv.xml@40">Patch Set #1, Line 40:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">red blob</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8303/1/tests/channels/pjsip/basic_calls/outgoing/nominal/early_media/sipp/ua1_invite_recv.xml@72">Patch Set #1, Line 72:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> <send retrans="500"><br> <![CDATA[<br><br> BYE sip:[service]@[remote_ip]:[remote_port] SIP/2.0<br> Via: SIP/2.0/[transport] [local_ip]:[local_port];branch=[branch]<br> From: ua1 <sip:ua1@[local_ip]:[local_port]>;tag=[pid]SIPpForkTag01[call_number]<br> To: [$remote_tag]<br> [last_Call-ID:]<br> CSeq: [cseq] BYE<br> Contact: <sip:[service]@[local_ip]:[local_port];transport=[transport]><br> Max-Forwards: 70<br> Subject: Path Test<br> Content-Length: 0<br><br> ]]><br> </send><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This test is fragile because of a race condition. The sipp script may or may not hangup the channel before Asterisk has a chance to execute the on-answer dialplan routine.</p><p style="white-space: pre-wrap; word-wrap: break-word;">You need to make it so Asterisk hangs up the call instead. Thus the sipp scenario needs to receive the BYE instead of send it.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8303/1/tests/channels/pjsip/basic_calls/outgoing/nominal/early_media/test-config.yaml">File tests/channels/pjsip/basic_calls/outgoing/nominal/early_media/test-config.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8303/1/tests/channels/pjsip/basic_calls/outgoing/nominal/early_media/test-config.yaml@12">Patch Set #1, Line 12:</a> <code style="font-family:monospace,monospace"> minversion: '14.0'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Minversion needs to be 15.4.0</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8303/1/tests/channels/pjsip/basic_calls/outgoing/nominal/early_media/test-config.yaml@17">Patch Set #1, Line 17:</a> <code style="font-family:monospace,monospace"> - asterisk : 'res_pjsip'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add test dependencies:</p><ul><li>asterisk: 'app_dial'</li><li>asterisk: 'app_softhangup'</li><li>asterisk: 'app_stack'</li><li>asterisk: 'app_userevent'</li><li>asterisk: 'func_channel'</li></ul></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8303">change 8303</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8303"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I62accd4f993a6f42c77661e4943c1e9df5fbe04c </div>
<div style="display:none"> Gerrit-Change-Number: 8303 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lvl <digium@lvlconsultancy.nl> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 06 Mar 2018 20:38:03 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>