<p>lvl <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8305">View Change</a></p><p>Patch set 3:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8305/3/res/res_pjsip_session.c">File res/res_pjsip_session.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8305/3/res/res_pjsip_session.c@893">Patch Set #3, Line 893:</a> <code style="font-family:monospace,monospace">                      ast_sip_session_media_state_free(session->pending_media_state);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This can never be non-NULL so you don't have to free it.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">If we reached this point, pending_media_state->topology will always be NULL, but doesn't pending_media_state itself always exist? (In this session's previous visit to handle_negotiated_sdp() it's ast_sip_session_media_state_reset() but not freed)</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8305">change 8305</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8305"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: If0d5150ffe6f38d8a854831fef37942258d4629c </div>
<div style="display:none"> Gerrit-Change-Number: 8305 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: lvl <digium@lvlconsultancy.nl> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 06 Mar 2018 15:33:33 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>