<p>Joshua Colp <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8374">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">This change should also be documented in the CHANGES file.</p><p>(7 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8374/2/res/res_pjsip_notify.c">File res/res_pjsip_notify.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/2/res/res_pjsip_notify.c@468">Patch Set #2, Line 468:</a> <code style="font-family:monospace,monospace"> struct notify_channel_data *data = ao2_alloc(sizeof(*data),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This doesn't require a lock so ao2_alloc_options should be used with AO2_ALLOC_OPT_LOCK_NOLOCK</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/2/res/res_pjsip_notify.c@737">Patch Set #2, Line 737:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> // keep the channel locked so the dialog can't go away<br> ast_debug(1, "Channel has active dialog: %p\n", dlg);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This message isn't useful as it is</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/2/res/res_pjsip_notify.c@742">Patch Set #2, Line 742:</a> <code style="font-family:monospace,monospace"> ast_log(LOG_NOTICE, "No active dialog for channel\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">To a user this is confusing as the channel name is not included</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/2/res/res_pjsip_notify.c@748">Patch Set #2, Line 748:</a> <code style="font-family:monospace,monospace"> ast_log(LOG_NOTICE, "Unable to create request to channel");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/2/res/res_pjsip_notify.c@757">Patch Set #2, Line 757:</a> <code style="font-family:monospace,monospace"> ast_log(LOG_NOTICE, "Unable to send request to channel\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/2/res/res_pjsip_notify.c@848">Patch Set #2, Line 848:</a> <code style="font-family:monospace,monospace"> if (!(data = data_create(ch, info))) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add a comment that this takes ownership of the channel</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/2/res/res_pjsip_notify.c@853">Patch Set #2, Line 853:</a> <code style="font-family:monospace,monospace"> ao2_cleanup(data);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">data can never be NULL here so ao2_ref can be used</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8374">change 8374</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8374"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: If7f3151a6d633e414d5dc319d5efc1443c43dd29 </div>
<div style="display:none"> Gerrit-Change-Number: 8374 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Nathan Bruning <nathan@iperity.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 05 Mar 2018 13:16:22 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>