<p>Sean Bright <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8374">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(13 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8374/1/include/asterisk/res_pjsip.h">File include/asterisk/res_pjsip.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/1/include/asterisk/res_pjsip.h@3112">Patch Set #1, Line 3112:</a> <code style="font-family:monospace,monospace">struct pjsip_dialog* ast_sip_get_dialog_for_channel(struct ast_channel* ch);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Coding guidelines: The '*' should have a space before it, not after it.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8374/1/res/res_pjsip.c">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/1/res/res_pjsip.c@4746">Patch Set #1, Line 4746:</a> <code style="font-family:monospace,monospace">struct pjsip_dialog* ast_sip_get_dialog_for_channel(struct ast_channel* ch) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Coding guidelines: The '*' should have a space before it, not after it.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/1/res/res_pjsip.c@4753">Patch Set #1, Line 4753:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> struct ast_sip_channel_pvt *channel = ast_channel_tech_pvt(ch);<br> struct ast_sip_session *session = channel->session;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">These declarations need to moved to the top of their enclosing block. The assignments can remain here if needed.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8374/1/res/res_pjsip_notify.c">File res/res_pjsip_notify.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/1/res/res_pjsip_notify.c@68">Patch Set #1, Line 68:</a> <code style="font-family:monospace,monospace"> If <literal>URI</literal> is used, the default outbound endpoint will be used</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">One too many spaces between 'the' and 'default'</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/1/res/res_pjsip_notify.c@302">Patch Set #1, Line 302:</a> <code style="font-family:monospace,monospace"> struct ast_channel* channel;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Coding guidelines: The '*' should have a space before it, not after it.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/1/res/res_pjsip_notify.c@465">Patch Set #1, Line 465:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">static struct notify_channel_data* notify_ami_channel_data_create(<br> struct ast_channel* channel, void *info)<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Coding guidelines: The '*' should have a space before it, not after it.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/1/res/res_pjsip_notify.c@734">Patch Set #1, Line 734:</a> <code style="font-family:monospace,monospace"> ast_log(LOG_DEBUG, "Sending notity on channel %s\n", ast_channel_name(data->channel));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use ast_debug() instead (and 'notify' is misspelled)</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/1/res/res_pjsip_notify.c@738">Patch Set #1, Line 738:</a> <code style="font-family:monospace,monospace"> ast_log(LOG_DEBUG, "Channel has active dialog: %p\n", dlg);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use ast_debug()</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/1/res/res_pjsip_notify.c@742">Patch Set #1, Line 742:</a> <code style="font-family:monospace,monospace"> ast_log(LOG_WARNING, "SIP NOTIFY - No active dialog for channel\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Drop the "SIP NOTIFY - " from all of these warnings & errors. Also, are all of these off-nominal paths really something that the user needs to be aware of via warnings/errors?</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/1/res/res_pjsip_notify.c@781">Patch Set #1, Line 781:</a> <code style="font-family:monospace,monospace"> struct ast_channel* channel, void *info);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Coding guidelines: The '*' should have a space before it, not after it.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/1/res/res_pjsip_notify.c@839">Patch Set #1, Line 839:</a> <code style="font-family:monospace,monospace"> // note: this increases the refcount of the channel</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Don't use C++ style comments</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/1/res/res_pjsip_notify.c@840">Patch Set #1, Line 840:</a> <code style="font-family:monospace,monospace"> struct ast_channel* ch = ast_channel_get_by_name(channel_name);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Coding guidelines: The '*' should have a space before it, not after it.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/1/res/res_pjsip_notify.c@842">Patch Set #1, Line 842:</a> <code style="font-family:monospace,monospace"> ast_log(LOG_WARNING, "No channel found with name %s", channel_name);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Does this really need to be logged? If not, consider making it an ast_debug().</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8374">change 8374</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8374"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: If7f3151a6d633e414d5dc319d5efc1443c43dd29 </div>
<div style="display:none"> Gerrit-Change-Number: 8374 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nathan Bruning <nathan@iperity.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 23 Feb 2018 12:45:03 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>