<p>Jasper van der Neut <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8309">View Change</a></p><p>Patch set 1:</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8309/1/bridges/bridge_simple.c">File bridges/bridge_simple.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8309/1/bridges/bridge_simple.c@131">Patch Set #1, Line 131:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">        requested_topology = ast_channel_get_stream_topology(requested_chan);<br> new_top<br></pre></blockquote></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">requested_topology is not used anywhere, just use<br> new_topology = ast_stream_topology_clone(ast_channel_get_stream_topology(requested_chan));</pre></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8309/1/bridges/bridge_simple.c@213">Patch Set #1, Line 213:</a> <code style="font-family:monospace,monospace">     /* c0 and c1 are unlocked by simple_bridge_request_stream_topology_change() */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">channel locking/unlocking should happen in the same context. So either inline simple_bridge_request_stream_topology_change or let it return 'new_topology' and then unlock the channels, call ast_channel_request_stream_topology_change and free the new topology here:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> new_topology = simple_bridge_request_stream_topology_change(c1, c0);<br> ast_channel_unlock(c1);<br> ast_channel_unlock(c0);<br> if (new_topology) {<br>   ast_channel_request_stream_topology_change(c1, new_topology, &simple_bridge);<br>   ast_stream_topology(new_topology);<br> }</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8309">change 8309</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8309"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ica5d78a6c7ecf4f0b95fb16de28d3889b32c4776 </div>
<div style="display:none"> Gerrit-Change-Number: 8309 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jasper van der Neut <jasper@isotopic.nl> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 21 Feb 2018 12:15:14 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>