<p>Jenkins2 <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/8210">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Richard Mudgett: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Jenkins2: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">res_pjsip: Use pjsip_sip_uri.user_param instead of other_param<br><br>There is a dedicated slot in the pjsip_sip_uri for the 'user'<br>parameter, so use that instead of adding to the list of generic URI<br>parameters.<br><br>Change-Id: I0a0ce8a60ecee27489735bf56fd707719d8c2ed6<br>---<br>M res/res_pjsip.c<br>1 file changed, 1 insertion(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/res/res_pjsip.c b/res/res_pjsip.c<br>index 7c8aabf..293665d 100644<br>--- a/res/res_pjsip.c<br>+++ b/res/res_pjsip.c<br>@@ -3126,8 +3126,6 @@<br> {<br>      pjsip_sip_uri *sip_uri;<br>       int i = 0;<br>-   pjsip_param *param;<br>-  static const pj_str_t STR_USER = { "user", 4 };<br>     static const pj_str_t STR_PHONE = { "phone", 5 };<br> <br>        if (!endpoint || !endpoint->usereqphone || (!PJSIP_URI_SCHEME_IS_SIP(uri) && !PJSIP_URI_SCHEME_IS_SIPS(uri))) {<br>@@ -3155,15 +3153,7 @@<br>            return;<br>       }<br> <br>- if (pjsip_param_find(&sip_uri->other_param, &STR_USER)) {<br>-         /* Don't add it if it's already there */<br>-             return;<br>-      }<br>-<br>- param = PJ_POOL_ALLOC_T(pool, pjsip_param);<br>-  param->name = STR_USER;<br>-   param->value = STR_PHONE;<br>- pj_list_insert_before(&sip_uri->other_param, param);<br>+  sip_uri->user_param = STR_PHONE;<br> }<br> <br> pjsip_dialog *ast_sip_create_dialog_uac(const struct ast_sip_endpoint *endpoint,<br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/8210">change 8210</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8210"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I0a0ce8a60ecee27489735bf56fd707719d8c2ed6 </div>
<div style="display:none"> Gerrit-Change-Number: 8210 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>