<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8131">View Change</a></p><p>Patch set 1:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8131/1/main/manager.c">File main/manager.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8131/1/main/manager.c@9509">Patch Set #1, Line 9509:</a> <code style="font-family:monospace,monospace">     ast_str_append(fields_string, 0,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Shouldn't we `return ast_str_append(...)`?  That way we return error if ast_str_append fails to expand.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8131">change 8131</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8131"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I92f36b855540743b208d76e274152ee2d758176d </div>
<div style="display:none"> Gerrit-Change-Number: 8131 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 01 Feb 2018 18:47:54 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>