<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8082">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(8 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8082/2/include/asterisk/res_pjsip.h">File include/asterisk/res_pjsip.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8082/2/include/asterisk/res_pjsip.h@3063">Patch Set #2, Line 3063:</a> <code style="font-family:monospace,monospace"> * \param data Data to pass to the matcher. May be NULL and does NOT need to be an ao2 object.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Passing data=NULL unregisters all monitors with the provided callback.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8082/2/include/asterisk/res_pjsip.h@3080">Patch Set #2, Line 3080:</a> <code style="font-family:monospace,monospace"> * \param data Data to pass to the matcher. May be NULL and does NOT need to be an ao2 object.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Passing data=NULL unregisteres all monitors with the provided callback.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8082/2/res/res_pjsip.c">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8082/2/res/res_pjsip.c@2897">Patch Set #2, Line 2897:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">int ast_sip_will_uri_survive_restart(pjsip_sip_uri *uri, pjsip_rx_data *rdata)<br>{<br> struct ast_sip_endpoint *endpoint = ast_pjsip_rdata_get_endpoint(rdata);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">We should be passing in endpoint rather than relying on it being stored in rdata. This will also eliminate unnecessary ao2_ref/unref's of endpoint.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8082/2/res/res_pjsip/pjsip_transport_events.c">File res/res_pjsip/pjsip_transport_events.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8082/2/res/res_pjsip/pjsip_transport_events.c@212">Patch Set #2, Line 212:</a> <code style="font-family:monospace,monospace"> for (idx = AST_VECTOR_SIZE(&monitored->monitors); idx--;) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If we find a monitor to remove we must not decrement idx. We need to keep idx the same for another loop. The simplest fix is to ++idx after removal from the vector.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8082/2/res/res_pjsip/pjsip_transport_events.c@216">Patch Set #2, Line 216:</a> <code style="font-family:monospace,monospace"> if (notifier->cb == cb_data->cb && (!cb_data->data || cb_data->matches(cb_data->data, notifier->data))) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Need to break the line for 90 columns.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8082/2/res/res_pjsip_outbound_registration.c">File res/res_pjsip_outbound_registration.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8082/2/res/res_pjsip_outbound_registration.c@881">Patch Set #2, Line 881:</a> <code style="font-family:monospace,monospace"> ast_sip_transport_monitor_register(transport, registration_transport_shutdown_cb, monitor);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Restore the line break at 90 and this removes any change to this function.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8082/2/res/res_pjsip_pubsub.c">File res/res_pjsip_pubsub.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8082/2/res/res_pjsip_pubsub.c@130">Patch Set #2, Line 130:</a> <code style="font-family:monospace,monospace"> <configOption name="prune_on_restart"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">prune_on_boot</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8082/2/res/res_pjsip_pubsub.c@3053">Patch Set #2, Line 3053:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">stray blank line</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8082">change 8082</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8082"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Iee87cf4eb9b7b2b93d5739a72af52d6ca8fbbe36 </div>
<div style="display:none"> Gerrit-Change-Number: 8082 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 29 Jan 2018 22:38:42 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>