<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8046">View Change</a></p><p>Patch set 1:</p><p style="white-space: pre-wrap; word-wrap: break-word;">Changes could also be added to spinlock.h but I'm not sure of the correct way to do that.  Since spinlock.h isn't included by anything I'd rather not touch it.</p><p style="white-space: pre-wrap; word-wrap: break-word;">https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html</p><p style="white-space: pre-wrap; word-wrap: break-word;">To preemptively answer about the preference order having __atomic first, the gcc docs for __sync are labeled "Legacy __sync Built-in Functions for Atomic Memory Access", it says new code should use __atomic builtins instead.</p><p style="white-space: pre-wrap; word-wrap: break-word;">https://gcc.gnu.org/onlinedocs/gcc/_005f_005fsync-Builtins.html</p><ul style="list-style: none; padding-left: 20px;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8046">change 8046</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8046"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I65b4feb02bae368904ed0fb03f585c05f50a690e </div>
<div style="display:none"> Gerrit-Change-Number: 8046 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 25 Jan 2018 02:27:55 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>