<p>Kevin Harwell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7705">View Change</a></p><p>Patch set 6:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7705/6/tests/channels/SIP/ami/sip_notify/call_id/configs/ast1/manager.conf">File tests/channels/SIP/ami/sip_notify/call_id/configs/ast1/manager.conf:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7705/6/tests/channels/SIP/ami/sip_notify/call_id/configs/ast1/manager.conf@1">Patch Set #6, Line 1:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[general]<br>enabled = yes<br>port = 5038<br><br>[user]<br>secret = mysecret<br>permit = 127.0.0.1/255.255.255.255<br>read = all<br>write = all<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The conf file is not needed as well and can be deleted.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7705/6/tests/channels/SIP/ami/sip_notify/call_id/test-config.yaml">File tests/channels/SIP/ami/sip_notify/call_id/test-config.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7705/6/tests/channels/SIP/ami/sip_notify/call_id/test-config.yaml@21">Patch Set #6, Line 21:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> - { 'key-args': {'scenario': 'caller.xml', '-i': '127.0.0.1', '-p': '5062', '-s': '3200000000', '-trace_msg': '-pause_msg_ign' } }<br> - { 'key-args': { 'scenario': 'callee.xml', '-i': '127.0.0.1', '-p': '5063', '-s': '3200000000', '-trace_msg': '-pause_msg_ign' } }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">It doesn't appear you are using the "-s" (service) parameters in your scenarios, so this option can be safely removed.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7705/6/tests/channels/SIP/ami/sip_notify/call_id/test-config.yaml@41">Patch Set #6, Line 41:</a> <code style="font-family:monospace,monospace"> minversion: [ '13.20.0', '15.3.0', '16.0.0' ]</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">While it shouldn't hurt things to be there 16.0.0 has not been released yet, so that version can be safely removed from the list.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7705">change 7705</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7705"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Idccbf32ed6670a5205ee99bd7413c7fe0804efb1 </div>
<div style="display:none"> Gerrit-Change-Number: 7705 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: Yasuhiko Kamata <yasuhiko.kamata@nxtg.co.jp> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Yasuhiko Kamata <yasuhiko.kamata@nxtg.co.jp> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 19 Jan 2018 21:06:08 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>