<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7872">View Change</a></p><p>Patch set 5:</p><p>(5 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7872/5/include/asterisk/module.h">File include/asterisk/module.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7872/5/include/asterisk/module.h@342">Patch Set #5, Line 342:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> /*! Modules which must be started first, in comma-separated string format. */<br> const char *requires;<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">"Modules which must be loaded and started first, in comma-separated string </blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">"Modules which must always be started first for this module to function, in comma-separated string format."</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7872/5/res/res_agi.c">File res/res_agi.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7872/5/res/res_agi.c@4720">Patch Set #5, Line 4720:</a> <code style="font-family:monospace,monospace"> .requires = "res_speech",</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">res_speech is not implemented with OPTIONAL_API so res_agi.so directly refe</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Well, that's a surprising dependency as I've loaded that module without res_speech.so installed. I think that is because the older version I'm using at home uses the RTLD_LAZY flag.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7872/5/res/res_ari.c">File res/res_ari.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7872/5/res/res_ari.c@1200">Patch Set #5, Line 1200:</a> <code style="font-family:monospace,monospace"> .optional_apis = "res_http_websocket",</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">What about some of the basic information retrieval URL's (no use of events)</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yeah, some requests don't need websockets to respond so technically it can be optional its just not as useful.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7872/5/res/res_pjsip.c">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7872/5/res/res_pjsip.c@5128">Patch Set #5, Line 5128:</a> <code style="font-family:monospace,monospace"> .requires = "res_pjproject,res_pjsip_config_wizard",</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Maybe it should move to .optional_apis? I know that the config wizard need</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">res_pjsip_config_wizard does need to be loaded and running before res_pjsip starts. However, all it's work is done using sorcery observers and wizards. It does not have to be loaded for res_pjsip to function if you are not using the config wizard for configuration.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7872/5/res/res_pjsip_outbound_publish.c">File res/res_pjsip_outbound_publish.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7872/5/res/res_pjsip_outbound_publish.c@1705">Patch Set #5, Line 1705:</a> <code style="font-family:monospace,monospace"> .requires = "res_pjproject,res_pjsip",</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This module directly calls ast_pjproject_get_buildopt. You are right it's </blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ok. That makes sense.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7872">change 7872</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7872"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I3ad9547a0a6442409ff4e352a6d897bef2cc04bf </div>
<div style="display:none"> Gerrit-Change-Number: 7872 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 15 Jan 2018 01:55:04 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>