<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7871">View Change</a></p><p>Patch set 5:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7871/5/main/strings.c">File main/strings.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7871/5/main/strings.c@411">Patch Set #5, Line 411:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  while ((cur = strsep(&buf, delim))) {<br>             if (excludes_cmp && AST_VECTOR_GET_CMP(dest, cur, !excludes_cmp)) {<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">The strip and empty string skip functionality would be:</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">So then should I replace excludes_cmp with an 'int flags' that would allow control of duplicate handling, trimming and skipping blanks?</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">enum ast_vector_string_split_flags {<br>  AST_VECTOR_STRING_SPLIT_EXCLUDE_BLANKS = 0x01,<br>  AST_VECTOR_STRING_SPLIT_EXCLUDE_DUPS = 0x02,<br>  AST_VECTOR_STRING_SPLIT_EXCLUDE_DUPS_I = 0x03,<br>  AST_VECTOR_STRING_SPLIT_TRIM = 0x08,<br>};</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7871">change 7871</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7871"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I1bf02a1efeb2baeea11c59c557d39dd1197494d7 </div>
<div style="display:none"> Gerrit-Change-Number: 7871 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 15 Jan 2018 00:05:28 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>