<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7896">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">We discussed on IRC and I believe this is the correct approach to fix this issue. This still needs to be mentioned in CHANGES.</p><p>(7 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7896/1/main/config.c">File main/config.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7896/1/main/config.c@2194">Patch Set #1, Line 2194:</a> <code style="font-family:monospace,monospace"> ast_verb(4, "Parsing '%s': Found\n", fn);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Let's just remove this line, the debug is good enough.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7896/1/main/pbx.c">File main/pbx.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7896/1/main/pbx.c@6210">Patch Set #1, Line 6210:</a> <code style="font-family:monospace,monospace"> ast_verb(6, "Registered extension context '%s'; registrar: %s\n", tmp->name, registrar);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Please switch to ast_debug(1, ...)</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7896/1/main/pbx.c@6217">Patch Set #1, Line 6217:</a> <code style="font-family:monospace,monospace"> ast_verb(6, "Registered extension context '%s'; registrar: %s\n", tmp->name, registrar);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This and the one just above can be de-duplicated, just do a single ast_debug before the return.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7896/1/main/pbx.c@6467">Patch Set #1, Line 6467:</a> <code style="font-family:monospace,monospace"> while ((tmp = ast_hashtab_next(iter))) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is a good place to count the contexts, ++ctx_count per run of the loop.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7896/1/main/pbx.c@6642">Patch Set #1, Line 6642:</a> <code style="font-family:monospace,monospace"> ast_verb(3,"Total time merge_contexts_delete: %8.6f sec\n", ft);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">After these lets add a message:<br>ast_verb(3, "%s successfully loaded %d contexts (enable debug for details).\n", registrar, ctx_count);</p><p style="white-space: pre-wrap; word-wrap: break-word;">This will tell how many contexts were loaded (appropriate for verbose 3) and tell people where to find the debug messages so they don't file a bug about this change.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7896/1/main/pbx.c@6702">Patch Set #1, Line 6702:</a> <code style="font-family:monospace,monospace"> ast_verb(6, "Including context '%s' in context '%s'\n",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Please switch to ast_debug(1, ...)</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7896/1/main/pbx.c@7519">Patch Set #1, Line 7519:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> if (tmp->matchcid == AST_EXT_MATCHCID_ON) {<br> ast_verb(6, "Added extension '%s' priority %d (CID match '%s') to %s\n",<br> tmp->name, tmp->priority, tmp->cidmatch_display, con->name);<br> } else {<br> ast_verb(6, "Added extension '%s' priority %d to %s\n",<br> tmp->name, tmp->priority, con->name);<br> }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Let's remove this, the ast_debug just above is enough.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7896">change 7896</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7896"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I5662902161c50890997ddc56835d4cafb456c529 </div>
<div style="display:none"> Gerrit-Change-Number: 7896 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Benoît Dereck-Tricot <benoit.dereck-tricot@eyepea.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 12 Jan 2018 17:42:37 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>