<p>Jenkins2 <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/7901">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Corey Farrell: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Jenkins2: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cdr_syslog: Deprecate unmaintained module<br><br>There has been an open issue against cdr_syslog (ASTERISK~14441) about<br>a race condition for 7.5 years that has never been addressed. Because<br>this module is effectively unmaintained and currently broken, there is<br>no sense in keeping it around.<br><br>If logging CDRs to syslog is a desirable feature, it would probably be<br>better to write the logs directly to the syslog server via socket<br>instead of using the facilities provided by openlog/syslog/closelog.<br>Doing so would address the race condition referenced in the associated<br>issue.<br><br>Change-Id: Ic77b94cd97f355a9cf5b1d3f3444964a6e0ba5dc<br>---<br>M CHANGES<br>M UPGRADE.txt<br>M cdr/cdr_syslog.c<br>3 files changed, 11 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/CHANGES b/CHANGES<br>index 84344aa..ec533e8 100644<br>--- a/CHANGES<br>+++ b/CHANGES<br>@@ -51,6 +51,11 @@<br>  * A new AMI action, PJSIPShowAuths, has been added which displays information<br>    about all configured PJSIP Auths.<br> <br>+cdr_syslog<br>+------------------<br>+ * The cdr_syslog module is now deprecated and by default it is no longer<br>+   built.<br>+<br> ------------------------------------------------------------------------------<br> --- Functionality changes from Asterisk 15.1.0 to Asterisk 15.2.0 ------------<br> ------------------------------------------------------------------------------<br>diff --git a/UPGRADE.txt b/UPGRADE.txt<br>index dd37b25..b2c75fb 100644<br>--- a/UPGRADE.txt<br>+++ b/UPGRADE.txt<br>@@ -40,6 +40,10 @@<br>  - The ContactInfo event's contact_status field is now set to "NonQualified"<br>    when a contact exists but has not been qualified.<br> <br>+cdr_syslog:<br>+ - The cdr_syslog module is now deprecated and by default it is no longer<br>+   built.<br>+<br> New in 15.0.0:<br> <br> Build System:<br>diff --git a/cdr/cdr_syslog.c b/cdr/cdr_syslog.c<br>index bbe2652..bbc4406 100644<br>--- a/cdr/cdr_syslog.c<br>+++ b/cdr/cdr_syslog.c<br>@@ -37,8 +37,9 @@<br>  */<br> <br> /*** MODULEINFO<br>+     <defaultenabled>no</defaultenabled><br>       <depend>syslog</depend><br>-  <support_level>core</support_level><br>+      <support_level>deprecated</support_level><br> ***/<br> <br> #include "asterisk.h"<br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/7901">change 7901</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7901"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ic77b94cd97f355a9cf5b1d3f3444964a6e0ba5dc </div>
<div style="display:none"> Gerrit-Change-Number: 7901 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>