<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7705">View Change</a></p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">Unfortunately this test is still not stopping correctly.  Here is the output I received (double-spacing stripped):<br>--> Running test 'tests/channels/SIP/ami/sip_notify/call_id' ...<br>Making sure Asterisk isn't running ...<br>Making sure SIPp isn't running...<br>Running ['tests/channels/SIP/ami/sip_notify/call_id/run-test'] ...<br>[Jan 11 12:55:05] WARNING[19540]: asterisk.test_case:531 _reactor_timeout: Reactor timeout: '10' seconds<br>[Jan 11 12:55:05] WARNING[19540]: asterisk.sipp:862 stop_asterisk: SIPp Scenario caller.xml has not exited; killing<br>[Jan 11 12:55:05] WARNING[19540]: asterisk.sipp:488 kill: Killing SIPp Scenario caller.xml<br>[Jan 11 12:55:05] WARNING[19540]: asterisk.sipp:862 stop_asterisk: SIPp Scenario callee.xml has not exited; killing<br>[Jan 11 12:55:05] WARNING[19540]: asterisk.sipp:488 kill: Killing SIPp Scenario callee.xml<br>Test ['tests/channels/SIP/ami/sip_notify/call_id/run-test', 'GIT-master-8a6febd980'] passed</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7705/3/tests/channels/SIP/ami/sip_notify/call_id/test-config.yaml">File tests/channels/SIP/ami/sip_notify/call_id/test-config.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7705/3/tests/channels/SIP/ami/sip_notify/call_id/test-config.yaml@8">Patch Set #3, Line 8:</a> <code style="font-family:monospace,monospace">    minversion: '12.0.0'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Sorry I missed this earlier but this is the incorrect version for this test.  The Call-ID feature is only in 'master' so minversion is 16.0.0.  Once this test is fully functional I have no problems with cherry-picking the feature to 13 and 15.  In that case you would want:<br>minversion: ['13.20.0', '15.3.0', '16.0.0']</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7705">change 7705</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7705"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Idccbf32ed6670a5205ee99bd7413c7fe0804efb1 </div>
<div style="display:none"> Gerrit-Change-Number: 7705 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Yasuhiko Kamata <yasuhiko.kamata@nxtg.co.jp> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Yasuhiko Kamata <yasuhiko.kamata@nxtg.co.jp> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 11 Jan 2018 17:57:36 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>