<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7902">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7902/1/main/stasis.c">File main/stasis.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7902/1/main/stasis.c@715">Patch Set #1, Line 715:</a> <code style="font-family:monospace,monospace">    idx = AST_VECTOR_REMOVE_ELEM_UNORDERED(&topic->subscribers, sub,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This has a type inconsistency.</p><p style="white-space: pre-wrap; word-wrap: break-word;">AST_VECTOR_REMOVE_ELEM_UNORDERED() returns 0 or -1 int.<br>idx is size_t which is unsigned.<br>Function returns int.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Probably should declare an "int res" to avoid any future stupid compiler warnings.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7902/1/main/stasis.c@1640">Patch Set #1, Line 1640:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">         if (aco_set_defaults(&declined_option, "declined_message_types", default_cfg->declined_message_types)) {<br>                     ast_log(LOG_ERROR, "Failed to load stasis.conf and failed to initialize defaults.\n");<br>                      return -1;<br>            }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">default_cfg leaked here.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7902">change 7902</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7902"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib11193531e797bcb16bba560a408eab155f706d1 </div>
<div style="display:none"> Gerrit-Change-Number: 7902 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 10 Jan 2018 21:50:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>