<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7833">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7833/2/res/res_stasis.c">File res/res_stasis.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7833/2/res/res_stasis.c@1939">Patch Set #2, Line 1939:</a> <code style="font-family:monospace,monospace">         blob = ast_json_pack("{ss}", "eventname", event_name);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">{s: s}</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7833/2/res/res_stasis.c@1948">Patch Set #2, Line 1948:</a> <code style="font-family:monospace,monospace">  multi = ast_multi_object_blob_create(blob);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Creation can fail and thus multi would be NULL.<br>The stasis_message_create() would crash below before this patch too but the new ao2_refs would now crash.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7833/2/res/stasis/app.c">File res/stasis/app.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7833/2/res/stasis/app.c@1222">Patch Set #2, Line 1222:</a> <code style="font-family:monospace,monospace">              int append_res = -1;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This no longer needs to be initialized.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7833/2/res/stasis/control.c">File res/stasis/control.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7833/2/res/stasis/control.c@929">Patch Set #2, Line 929:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ao2_lock(chan);<br>       bridge_channel = ast_channel_internal_bridge_channel(chan);<br>   ao2_unlock(chan);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should be ast_channel_lock/ast_channel_unlock</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7833">change 7833</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7833"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I4ce67120583a446babf9adeec678b71d37fcd9e5 </div>
<div style="display:none"> Gerrit-Change-Number: 7833 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 07 Jan 2018 21:16:38 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>