<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7819">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7819/1/bridges/bridge_softmix.c">File bridges/bridge_softmix.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7819/1/bridges/bridge_softmix.c@1407">Patch Set #1, Line 1407:</a> <code style="font-family:monospace,monospace">            check_binaural_position_change(bridge, softmix_data, bridge_channel);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I assume the uninitialized variable warning comes from here?  If so I'm not sure if this call should always use bridge_channel == NULL, or if check_binaural_position_change should be called from within the bridge->channels traversal?  I don't know anything about the binaural code so I could be wrong.</p><p style="white-space: pre-wrap; word-wrap: break-word;">If this function is intended to be called with a NULL 3rd parameter I think we should just pass NULL explicitly, rather than passing a NULL bridge_channel variable.  That way if code order changes in the future and bridge_channel gets reset before this call we won't use the wrong value.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7819">change 7819</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7819"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I8af3bd84656b685a956d498459f8db3613f68954 </div>
<div style="display:none"> Gerrit-Change-Number: 7819 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alexander Traud <pabstraud@compuserve.com> </div>
<div style="display:none"> Gerrit-Reviewer: Alexander Traud <pabstraud@compuserve.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 05 Jan 2018 17:08:27 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>