<p>Corey Farrell has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/7678">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bridge: Old channel video source not set to NULL after unref.<br><br>The bridge holds onto the old channel video source after it's been<br>released. This can lead to use after free errors.<br><br>ASTERISK-27229 #close<br><br>Change-Id: Ib2dab61677dd8a21f7ad53cdc9b8ca93297838b3<br>---<br>M main/bridge.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/78/7678/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/main/bridge.c b/main/bridge.c<br>index 5e065fb..8284fd3 100644<br>--- a/main/bridge.c<br>+++ b/main/bridge.c<br>@@ -3808,7 +3808,7 @@<br> data->average_talking_energy = talker_energy;<br> } else if ((data->average_talking_energy < talker_energy) && is_keyframe) {<br> if (data->chan_old_vsrc) {<br>- ast_channel_unref(data->chan_old_vsrc);<br>+ data->chan_old_vsrc = ast_channel_unref(data->chan_old_vsrc);<br> }<br> if (data->chan_vsrc) {<br> data->chan_old_vsrc = data->chan_vsrc;<br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/7678">change 7678</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7678"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib2dab61677dd8a21f7ad53cdc9b8ca93297838b3 </div>
<div style="display:none"> Gerrit-Change-Number: 7678 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>