<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7657">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7657/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7657/1//COMMIT_MSG@9">Patch Set #1, Line 9:</a> <code style="font-family:monospace,monospace">It seems that the ALSA backend of PortAudio doesn't know how to to both</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/to to/to/</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7657/1/channels/chan_console.c">File channels/chan_console.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7657/1/channels/chan_console.c@172">Patch Set #1, Line 172:</a> <code style="font-family:monospace,monospace">  ast_mutex_t mutex;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You don't necessarily have to add a lock.  The struct console_pvt is an ao2 object with a lock.  You could use console_pvt_lock()/console_pvt_unlock() instead of managing your own lock.</p><p style="white-space: pre-wrap; word-wrap: break-word;">As it is, the new lock should be initialized in init_pvt() when the pvt struct is created and destroyed in pvt_destructor() which is the ao2 object destructor.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7657">change 7657</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7657"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I635eacee45f5413faa18f5a3b606af03b926dacb </div>
<div style="display:none"> Gerrit-Change-Number: 7657 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Tzafrir Cohen <tzafrir.cohen@xorcom.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 19 Dec 2017 22:01:24 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>