<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7663">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7663/2/main/asterisk.c">File main/asterisk.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7663/2/main/asterisk.c@1724">Patch Set #2, Line 1724:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                       if (setsockopt(s, SOL_SOCKET, SO_PASSCRED, &sckopt, sizeof(sckopt)) < 0) {<br>                             ast_log(LOG_WARNING, "Unable to turn on socket credentials passing\n");<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Shouldn't we be closing s here?</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7663/2/main/manager.c">File main/manager.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7663/2/main/manager.c@2373">Patch Set #2, Line 2373:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                                    char *syntax = ast_xmldoc_printable(S_OR(cur->syntax, "Not available"), 1);<br>                                      char *synopsis = ast_xmldoc_printable(S_OR(cur->synopsis, "Not available"), 1);<br>                                  char *description = ast_xmldoc_printable(S_OR(cur->description, "Not available"), 1);<br>                                    char *arguments = ast_xmldoc_printable(S_OR(cur->arguments, "Not available"), 1);<br>                                        char *seealso = ast_xmldoc_printable(S_OR(cur->seealso, "Not available"), 1);<br>                                    char *privilege = ast_xmldoc_printable(S_OR(auth_str, "Not available"), 1);<br>                                 char *responses = ast_xmldoc_printable("None", 1);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">We should free these and abort the command if any returns NULL.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7663/2/pbx/pbx_config.c">File pbx/pbx_config.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7663/2/pbx/pbx_config.c@1530">Patch Set #2, Line 1530:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                       if (!partial_match(ast_get_context_name(c), a->word, len))<br>                         continue;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This leaves context c locked.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7663">change 7663</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7663"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I8f633ceb1714867ae30ef4e421858f77c14485a9 </div>
<div style="display:none"> Gerrit-Change-Number: 7663 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 19 Dec 2017 20:32:47 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>