<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7629">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">Some additional things beyond what the compiler complains about in the localtime.c file.</p><p>(6 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7629/1/main/stdtime/localtime.c">File main/stdtime/localtime.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7629/1/main/stdtime/localtime.c@1549">Patch Set #1, Line 1549:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                                 ** If summer time is in effect, and the<br>                                       ** transition time was not specified as<br>                                       ** standard time, add the summer time<br>                                 ** offset to the transition time;<br>                                     ** otherwise, add the standard time<br>                                   ** offset to the transition time.<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This comment needs updating too.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7629/1/res/res_config_ldap.c">File res/res_config_ldap.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7629/1/res/res_config_ldap.c@312">Patch Set #1, Line 312:</a> <code style="font-family:monospace,monospace"> int i = 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">i is not used anymore</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7629/1/res/res_config_ldap.c@315">Patch Set #1, Line 315:</a> <code style="font-family:monospace,monospace">        int pos = 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">pos is a constant now and only used in a couple places after the removed code.</p><p style="white-space: pre-wrap; word-wrap: break-word;">With the additional changes below pos is no longer needed either.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7629/1/res/res_config_ldap.c@340">Patch Set #1, Line 340:</a> <code style="font-family:monospace,monospace">                                 /* for the last delimited value or if the value is not delimited: */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This comment now needs updating.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7629/1/res/res_config_ldap.c@342">Patch Set #1, Line 342:</a> <code style="font-family:monospace,monospace">                                           prev->next = ast_variable_new(attribute_name, &valptr[pos], table_config->table_name);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/&valptr[pos]/valptr/</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7629/1/res/res_config_ldap.c@347">Patch Set #1, Line 347:</a> <code style="font-family:monospace,monospace">                                             prev = var = ast_variable_new(attribute_name, &valptr[pos], table_config->table_name);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/&valptr[pos]/valptr/</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7629">change 7629</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7629"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I62e2aac353d739fb3c983cf768933120f5fba059 </div>
<div style="display:none"> Gerrit-Change-Number: 7629 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 18 Dec 2017 22:16:38 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>