<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7560">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(6 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7560/2/channels/chan_iax2.c">File channels/chan_iax2.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7560/2/channels/chan_iax2.c@3674">Patch Set #2, Line 3674:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                        ast_cli_complete(a->word, choices, -1);<br>                    return complete_iax2_peers(a->line, a->word, a->pos, a->n, IAX_RTCACHEFRIENDS);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think this is going to add "all" to the vector for every matching peer IAX2 has.  If you also make complete_iax2_peers() work similarly or always do ast_cli_completion_add() you wouldn't have the duplication of "all".</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7560/2/channels/chan_sip.c">File channels/chan_sip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7560/2/channels/chan_sip.c@20486">Patch Set #2, Line 20486:</a> <code style="font-family:monospace,monospace">                      return complete_sip_peer(a->word, a->n, SIP_PAGE2_RTCACHEFRIENDS);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same about duplicating matching choices.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7560/2/channels/chan_skinny.c">File channels/chan_skinny.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7560/2/channels/chan_skinny.c@3930">Patch Set #2, Line 3930:</a> <code style="font-family:monospace,monospace">         return complete_skinny_devices(word, state);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7560/2/include/asterisk/cli.h">File include/asterisk/cli.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7560/2/include/asterisk/cli.h@206">Patch Set #2, Line 206:</a> <code style="font-family:monospace,monospace"> * matching channels are added with ast_cli_completion_add.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/channels/choices/</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7560/2/main/bridge.c">File main/bridge.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7560/2/main/bridge.c@5217">Patch Set #2, Line 5217:</a> <code style="font-family:monospace,monospace">                 return complete_bridge_participant(a->argv[2], a->line, a->word, a->pos, a->n);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7560/2/main/cli.c">File main/cli.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7560/2/main/cli.c@1511">Patch Set #2, Line 1511:</a> <code style="font-family:monospace,monospace">           ast_complete_channels(a->line, a->word, a->pos, a->n, -1);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Changed wrong parameter.</p><p style="white-space: pre-wrap; word-wrap: break-word;">s/a->n, -1/-1, 3/</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7560">change 7560</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7560"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Iebef61424689569338d0916ff2e37df944ac76fa </div>
<div style="display:none"> Gerrit-Change-Number: 7560 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 15 Dec 2017 22:58:18 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>