<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7518">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7518/1/main/loader.c">File main/loader.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7518/1/main/loader.c@198">Patch Set #1, Line 198:</a> <code style="font-family:monospace,monospace">    mod = resource_being_loaded;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why not set resource_being_loaded to NULL here since we are taking the resource and putting it into the list.  This way load_dynamic_module() doesn't need to know we stick it on the end of the list and we don't need these comments proclaiming dire consequences if it isn't put on the end.  It just needs to see that resource_being_loaded became NULL after dlopen().</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7518/1/main/loader.c@574">Patch Set #1, Line 574:</a> <code style="font-family:monospace,monospace">          return NULL;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Isn't mod leaked here?  The module didn't register itself so it shouldn't be in the module_list and nobody else should know about it now.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7518">change 7518</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7518"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I40f07a315e55b92df4fc7faf525ed6d4f396e7d2 </div>
<div style="display:none"> Gerrit-Change-Number: 7518 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 14 Dec 2017 23:20:58 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>